Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-21075 Move UMutex global statics to function statics #1110

Closed
wants to merge 1 commit into from
Closed

ICU-21075 Move UMutex global statics to function statics #1110

wants to merge 1 commit into from

Conversation

daniel-ju
Copy link
Contributor

DO NOT MERGE. This is a public patch for the global statics issue if others hit the issue and want a fix. This is a Windows-only issue when building ICU on VS2017 and below.

Checklist

@daniel-ju daniel-ju requested review from aheninger and jefgen April 16, 2020 01:44
@jefgen jefgen added the do-not-merge Ready for review but shouldn't be merged yet (useful when ICU is preparing for a release) label Apr 16, 2020
jefgen
jefgen approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@jefgen jefgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, (but don't check it in. :) )

@daniel-ju daniel-ju closed this Apr 20, 2020
@daniel-ju daniel-ju deleted the daju/global-statics-umutex branch June 11, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefgen jefgen jefgen approved these changes

@aheninger aheninger Awaiting requested review from aheninger

Assignees

@jefgen jefgen

Labels
do-not-merge Ready for review but shouldn't be merged yet (useful when ICU is preparing for a release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-ju @jefgen