Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2356] Use state updater to sync up state transitions #1704

Closed
wants to merge 30 commits into from
Closed

[UNDERTOW-2356] Use state updater to sync up state transitions #1704

wants to merge 30 commits into from

Conversation

baranowb
Copy link
Contributor

@baranowb baranowb added enhancement Enhances existing behaviour or code under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review labels Nov 14, 2024
@baranowb baranowb requested review from ropalka and fl4via November 14, 2024 09:15
jasondlee
jasondlee approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@jasondlee jasondlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@baranowb baranowb changed the title [UNDERTOW-2356] Use state updated to sync up state transitions [UNDERTOW-2356] Use state updater to sync up state transitions Dec 5, 2024
baranowb and others added 21 commits December 5, 2024 11:12
@baranowb
[UNDERTOW-2333] introduce WebSocket IO specific timeouts
2407a63
@baranowb
[UNDERTOW-2333] Add websocket timeout testcase
7bd8b50
@fl4via @baranowb
[UNDERTOW-2518] Tidy up WebSocketTimeoutTestCase and make it uset @Be…
3f771bf 
…foreServerStarts and @AfterServerStops for simpler before and after methods

Signed-off-by: Flavia Rainone <frainone@redhat.com>
@fl4via @baranowb
[UNDERTOW-2518] At WebSocketTimeoutTestCase, use a longer watch timeo…
f2d4424 
…ut to verify if the timeout is working, and increase the interval of tolerance for the time spent

This may work better on slower machines when running this test.

Signed-off-by: Flavia Rainone <frainone@redhat.com>
@fl4via @baranowb
Revert "[UNDERTOW-2279] Re-enable LotsOfHeadersResponseTestCase in Wi…
ab5ec01 
…ndows"

The tests were disabled in CI by mistake and this prevented us seeing that those tests still need to be fixed so they can work in Windows

This reverts commit abc70e2.
@xjusko @baranowb
[UNDERTOW-2404] Add default sorting by type and name in directory lis…
e7be76b 
…ting view; enable clickable name and size column headers for custom sorting
@baranowb
[UNDERTOW-2462] Adding default constant for ALLOW_ENCODED_SLASH
c05e8eb
@lvydra @baranowb
[UNDERTOW-2505] Review anonymous classes in Undertow io.undertow.webs…
18afeb2 
…ockets.jsr.test.suspendresume
@baranowb
[UNDERTOW-2509] Add 413 response code to overflowing multipart in def…
02136be 
…ault handler
@lvydra @baranowb
[UNDERTOW-2504] Review anonymous classes in Undertow io.undertow.webs…
9012f07 
…ockets.jsr.test.security
@baranowb
[UNDERTOW-2356] Add logger method
9d80a6e
@baranowb
[UNDERTOW-2356] AjpClientConnection
6f665d1
@baranowb
[UNDERTOW-2356] AjpClientExchange
04b2ffa
@baranowb
[UNDERTOW-2356] HttpClientConnection
9b5ef8c
@baranowb
[UNDERTOW-2356] HttpClientExchange
7b899d4
@baranowb
[UNDERTOW-2356] ChunkedStreamSinkConduit
94c8d14
@baranowb
[UNDERTOW-2356] DeflatingStreamSinkConduit
a55efee
@baranowb
[UNDERTOW-2356] UndertowInputStream UndertowOutputStream
fcfa9d8
@baranowb
[UNDERTOW-2356] HeadStreamSinkConduit
1078716
@baranowb
[UNDERTOW-2356] HttpServerExchange
15c128d
@baranowb
[UNDERTOW-2356] GracefulShutdownHandler - just suppress warnin
d388254
@baranowb
Copy link
Contributor Author

baranowb commented Dec 5, 2024

ok,. this is BS. git rebase is broken. Im going to redo PR

@baranowb baranowb closed this Dec 5, 2024
@baranowb
Copy link
Contributor Author

baranowb commented Dec 5, 2024

Check #1711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasondlee jasondlee jasondlee approved these changes

@ropalka ropalka Awaiting requested review from ropalka

@fl4via fl4via Awaiting requested review from fl4via

Assignees
No one assigned
Labels
enhancement Enhances existing behaviour or code under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@baranowb @jasondlee @fl4via @xjusko @lvydra