Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2446] HttpServletRequestImpl.getParts shouldn't throw exception after already loading parts #1666

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[UNDERTOW-2446] HttpServletRequestImpl.getParts shouldn't throw exception after already loading parts #1666

merged 1 commit into from
Oct 4, 2024

Conversation

aogburn
Copy link
Contributor

@aogburn aogburn commented Sep 20, 2024

@baranowb baranowb requested review from fl4via and baranowb September 30, 2024 09:57
@baranowb baranowb added enhancement Enhances existing behaviour or code under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review labels Sep 30, 2024
@baranowb
Copy link
Contributor

This does seem to align with apache impl: https://github.com/apache/tomcat/blob/main/java/org/apache/catalina/connector/Request.java#L2411

@fl4via fl4via added next release This PR will be merged before next release or has already been merged (for payload double check) and removed under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting peer review PRs that edit core classes might require an extra review labels Oct 4, 2024
@fl4via fl4via merged commit dc41f08 into undertow-io:main Oct 4, 2024
11 checks passed
@fl4via fl4via removed the waiting CI check Ready to be merged but waiting for CI check label Oct 4, 2024
@gaol gaol mentioned this pull request Oct 11, 2024
Closed
This was referenced Oct 16, 2024
Merged
Merged
@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baranowb baranowb baranowb approved these changes

@fl4via fl4via fl4via approved these changes

Assignees
No one assigned
Labels
enhancement Enhances existing behaviour or code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aogburn @baranowb @fl4via