Merge pull request #1690 from lvydra/UNDERTOW-2505

[UNDERTOW-2505] Review anonymous classes in Undertow io.undertow.websockets.jsr.test.suspendresume
undertow-io · Oct 23, 2024 · 73e7147 · 73e7147
2 parents e454886 + 2b098ae
commit 73e7147
Showing 1 changed file with 30 additions and 20 deletions.
diff --git a/...sr/src/test/java/io/undertow/websockets/jsr/test/suspendresume/SuspendResumeTestCase.java b/...sr/src/test/java/io/undertow/websockets/jsr/test/suspendresume/SuspendResumeTestCase.java
@@ -109,26 +109,7 @@ public void testConnectionWaitsForMessageEnd() throws Exception {
         final AtomicReference<String> message = new AtomicReference<>();
         WebSocketChannel channel = WebSocketClient.connectionBuilder(DefaultServer.getWorker(), DefaultServer.getBufferPool(), new URI(DefaultServer.getDefaultServerURL() + "/"))
                 .connect().get();
-        channel.getReceiveSetter().set(new AbstractReceiveListener() {
-            @Override
-            protected void onFullTextMessage(WebSocketChannel channel, BufferedTextMessage msg) {
-                message.set(msg.getData());
-                done.countDown();
-            }
-
-            @Override
-            protected void onError(WebSocketChannel channel, Throwable error) {
-                error.printStackTrace();
-                message.set("error");
-                done.countDown();
-            }
-
-            @Override
-            protected void onFullCloseMessage(WebSocketChannel channel, BufferedBinaryMessage message) {
-                message.getData().free();
-                done.countDown();
-            }
-        });
+        channel.getReceiveSetter().set(new ReceiveListener(message, done));
         channel.resumeReceives();
         Assert.assertTrue(channel.isOpen());
         WebSockets.sendText("Hello World", channel, null);
@@ -194,4 +175,33 @@ public void testRejectWhenSuspended() throws Exception {
         }
 
     }
+
+    private static class ReceiveListener extends AbstractReceiveListener {
+        private final CountDownLatch done;
+        private final AtomicReference<String> message;
+
+        ReceiveListener(AtomicReference<String> message, CountDownLatch done) {
+            this.message = message;
+            this.done = done;
+        }
+
+        @Override
+        protected void onFullTextMessage(WebSocketChannel channel, BufferedTextMessage msg) {
+            message.set(msg.getData());
+            done.countDown();
+        }
+
+        @Override
+        protected void onError(WebSocketChannel channel, Throwable error) {
+            error.printStackTrace();
+            message.set("error");
+            done.countDown();
+        }
+
+        @Override
+        protected void onFullCloseMessage(WebSocketChannel channel, BufferedBinaryMessage message) {
+            message.getData().free();
+            done.countDown();
+        }
+    }
 }