-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove or demote Codeclimate #610
Comments
I don't really care for it so I vote remove - it shouldn't be an insurmountable task to get our smaller apps into compliance and just all-or-nothing global lint as a ci step |
This addreses #610 in that Codeclimate won't _fail_ while we work on something more drastic.
Part of #610, let's try to avoid those red Xs for now
I don't really see why we're running rubocop on CodeClimate, at the very least. We have Travis doing the same thing, except we have much more control over how Travis works? The other checks can't hurt, although I assume we're paying for code climate... |
I wasn't around when it was added, but it offers an enticing set of features, namely having all your linters run and their outputs displayed prettily in one place, the ability to only enforce new offenses (more on this later), coverage drop checking and a bunch of other nebulous metrics about your code.
Travis doesn't currently run rubocop no, it strictly does the test suite. To get travis to do this and be helpful we either have to get the whole app linted as I mentioned above, or find some way to check if we're adding new offenses
We're most definitely on a free, open-source plan |
Throughout writing that whole message, I just realized that I mixed up rubocop and rspec. It's definitely the end of the day |
Part of #610, let's try to avoid those red Xs for now
I'm getting a bit weary of their rubocop system that requires them to publish their own Rubocop "engine" every time there's an update. They also need to think that the same Rubocop extensions are "important" as we do.
We can keep it, maybe, but let's move linting to someplace else in the CI
The text was updated successfully, but these errors were encountered: