add soft delete to card, deck, membership, and user #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When migrating fresh, old migrations will fail if they use the eloquent model directly instead of `DB::table` because the model now expects a `deleted_at` column. This rewrites the migrations to use DB::table.
adding soft deletes on deck memberships introduces complexity. Because there's a uniqueness constrain on the `deck_memberships` table, re-adding a member would mean that we need to restore the previous membership OR we need to work around the uniqueness constraint (perhaps by adding an additional constraint of `deleted_at`). In practice though, we don't need this soft delete. The user's practice data is directly associated with the `user_id` and the `deck_id`, not a `deck_memberships.id`. So if we removing a deck membership, any practice data would not be swept up in the cascade.
matching previous state for cleaner pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds soft delete functionality to:
The Deck Invite controller is updated so that if a membership was previously soft deleted and the user clicks on a share link to rejoin, the controller will restore the membership and set the role to match the link (which maybe be different from when they were last a member).
On dev for testing.