Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: share link demotes members #106

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

jxjj
Copy link
Collaborator

@jxjj jxjj commented Jan 22, 2025

This adds a check to make sure we're not accidentally demoting members who click on the "view" or "edit" share links.

only create/update memberships if there's no membership or the existing member can be promoted to a role
@jxjj jxjj requested a review from cmcfadden January 22, 2025 21:37
@jxjj jxjj self-assigned this Jan 22, 2025
@jxjj jxjj merged commit 85e50f6 into develop Jan 22, 2025
2 checks passed
@jxjj jxjj deleted the feature/fix-share-link-demotes-members branch January 22, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants