Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: url input is hidden after first keystroke #105

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

jxjj
Copy link
Collaborator

@jxjj jxjj commented Jan 22, 2025

fixes #104

On the card edit/create page, the audio block will hide the input field once there's some text in it. This is fine if copy/pastes a url, but if they're typing a url for some reason the user won't be able to continue after first character. Additionally, whether the url is valid or not an audio player shows.

This changes the block to be similar to the image block:

  • the url field is always visible
  • invalid urls will show an error, not try rendering an audio component

@jxjj jxjj merged commit 1a9f131 into develop Jan 22, 2025
1 of 2 checks passed
@jxjj jxjj deleted the feature/104-input-goes-away-in-audio-block branch January 22, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User can't type url for audio block
1 participant