Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] fix: dynamicImport getInitialProps can't work in ssr #3348

Closed
wants to merge 4 commits into from
Closed

[WIP] fix: dynamicImport getInitialProps can't work in ssr #3348

wants to merge 4 commits into from

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented Oct 2, 2019 •
edited
Loading

Close #2912.

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

This change is Reviewable

@label-actions
Copy link

label-actions bot commented Oct 2, 2019

@ycjcl868 请看下。

@netlify
Copy link

netlify bot commented Oct 2, 2019 •
edited
Loading

Ant Design Pro preview using the current branch umi

Built with commit 1d2821b

https://deploy-preview-3348--pro-pre-umijs.netlify.com

@coveralls
Copy link

coveralls commented Oct 2, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 7534

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 42.126%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/umi/src/dynamic.js 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
packages/umi/src/dynamic.js 1 0.0%
Totals Coverage Status
Change from base Build 7464: -0.02%
Covered Lines: 4450
Relevant Lines: 10510
💛 - Coveralls

@vercel vercel bot temporarily deployed to staging October 2, 2019 10:07 Inactive
@ycjcl868 ycjcl868 changed the title fix: dynamicImport getInitialProps can't work in ssr [WIP] fix: dynamicImport getInitialProps can't work in ssr Oct 2, 2019
@weekly-digest weekly-digest bot mentioned this pull request Oct 6, 2019
Closed
This was referenced Dec 2, 2019
Closed
Merged
@ycjcl868 ycjcl868 closed this Dec 6, 2019
@ycjcl868 ycjcl868 deleted the fix-ssr-dynamic-getInitialProps branch December 6, 2019 09:47
@ycjcl868 ycjcl868 mentioned this pull request May 15, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg(umi-plugin-dva) pr(bug) type(ssr) UmiJS SSR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

使用SSR的同时，使用 dynamicImport:true。在客户端无法执行 getInitialProps
2 participants
@ycjcl868 @coveralls