fix: remove helmet when in client bundle umi.js

umijs · May 15, 2020 · 97e4bf4 · 97e4bf4
1 parent fb58852
commit 97e4bf4
Showing 1 changed file with 33 additions and 26 deletions.
diff --git a/packages/plugin-helmet/src/templates/runtime.tpl b/packages/plugin-helmet/src/templates/runtime.tpl
@@ -1,30 +1,37 @@
 {{#SSR}}
-import { Helmet } from '{{{ HelmetPkg }}}';
-
-export const ssr = {
-  modifyServerHTML: (html, { cheerio }) => {
-    const helmet = Helmet.renderStatic();
-    if (!helmet) return html;
-    const title = helmet.title.toString();
-    const htmlAttributes = helmet.htmlAttributes.toComponent();
-    const meta = helmet.meta.toString();
-    const link = helmet.link.toString();
-    const $ = cheerio.load(html);
-    if (title) {
-      $('head').prepend(title);
-    }
-    if (meta) {
-      $('head').append(meta);
-    }
-    if (link) {
-      $('link').append(link);
+let ssr = {};
+// remove when client bundle umi.js
+if (process.env.__IS_SERVER) {
+  ssr = {
+    modifyServerHTML: (html, { cheerio }) => {
+      const { Helmet } = require('{{{ HelmetPkg }}}');
+      const helmet = Helmet.renderStatic();
+      if (!helmet) return html;
+      const title = helmet.title.toString();
+      const htmlAttributes = helmet.htmlAttributes.toComponent();
+      const meta = helmet.meta.toString();
+      const link = helmet.link.toString();
+      const $ = cheerio.load(html);
+      if (title) {
+        $('head').prepend(title);
+      }
+      if (meta) {
+        $('head').append(meta);
+      }
+      if (link) {
+        $('link').append(link);
+      }
+      if (Object.keys(htmlAttributes)) {
+        Object.keys(htmlAttributes).forEach(attrKey => {
+          $('html').attr(attrKey, htmlAttributes[attrKey]);
+        });
+      }
+      return $.html();
     }
-    if (Object.keys(htmlAttributes)) {
-      Object.keys(htmlAttributes).forEach(attrKey => {
-        $('html').attr(attrKey, htmlAttributes[attrKey]);
-      });
-    }
-    return $.html();
-  }
+  };
+}
+
+export {
+  ssr
 };
 {{/SSR}}