test: increase x/oracle unit test coverage #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamewozniak
added a commit
that referenced
this pull request
Apr 7, 2022
toteki
reviewed
Apr 7, 2022
| }{ | ||
| { | ||
| val: []byte("addr________________"), | ||
| expectedKey: []byte{0x4, 0x14, 0x61, 0x64, 0x64, 0x72, 0x5f, 0x5f, 0x5f, 0x5f, 0x5f, 0x5f, 0x5f, 0x5f, 0x5f, 0x5f, 0x5f, 0x5f, 0x5f, 0x5f, 0x5f, 0x5f}, |
There was a problem hiding this comment.
Could add a comment as to the origin of these bytes - that would also clarify what the meaning would be if the test ever failed.
There was a problem hiding this comment.
For example:
// keyPrefixAggregateExchangeRatePrevote | lengthPrefixed(addr)
|
Changelog entry pls! Don't be like me |
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #782 +/- ##
==========================================
- Coverage 48.03% 47.87% -0.16%
==========================================
Files 64 64
Lines 9329 9426 +97
==========================================
+ Hits 4481 4513 +32
- Misses 4581 4646 +65
Partials 267 267
|
toteki
approved these changes
Apr 7, 2022
adamewozniak
approved these changes
Apr 7, 2022
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2022
* chore: increasce test coverage * rename variables Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com> * moved test vars and const to test_utils * add comments to keys * fix string unit test * add changelog Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com> Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com> (cherry picked from commit 2343d70)
toteki
pushed a commit
that referenced
this pull request
Apr 8, 2022
* chore: increasce test coverage * rename variables Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com> * moved test vars and const to test_utils * add comments to keys * fix string unit test * add changelog Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com> Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com> (cherry picked from commit 2343d70) Co-authored-by: Rafael Tenfen <rafaeltenfen.rt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
x/oracle/types/denom.goandx/oracle/types/keys.gohelps: #661
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change