-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add param SmallLiquidationSize #723
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toteki
commented
Mar 29, 2022
RafilxTenfen
approved these changes
Mar 30, 2022
Weird, protobuf is also failing at main |
Afaik that test has been failing if there are any protobuff changes for a while - we should definitely fix it, but shouldn't be a problem in this PR |
adamewozniak
approved these changes
Mar 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Mar 30, 2022
(cherry picked from commit d9903f7)
toteki
added a commit
that referenced
this pull request
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a borrower's borrowed value (in USD) is lower than this
sdk.Dec
parameter, theirCloseFactor
will be1.0
once they are eligible for liquidation.Thus, "small" borrows abandoned by their users are not chipped away at forever by ~1% MinimumCloseFactor liquidations, never reaching zero, but can instead by finished off.
The default SmallLiquidationSize is $100.00
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change