Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cosmos sdk #2363

Merged
merged 8 commits into from
Jan 2, 2024
Merged

chore: bump cosmos sdk #2363

merged 8 commits into from
Jan 2, 2024

Conversation

robert-zaremba
Copy link
Member

@robert-zaremba robert-zaremba commented Dec 20, 2023

Description

Update cosmos-sdk to v0.47.7

Summary by CodeRabbit

  • Improvements
    • Upgraded to Cosmos SDK v0.47.7 for enhanced performance and stability.
    • Modified BroadcastTx method for improved transaction handling.

@robert-zaremba robert-zaremba requested a review from a team as a code owner December 20, 2023 09:56
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 98 lines in your changes are missing coverage. Please review.

Comparison is base (7f05ad4) 75.38% compared to head (3d7c741) 70.03%.
Report is 333 commits behind head on main.

❗ Current head 3d7c741 differs from pull request most recent head 96ea97a. Consider uploading reports for the commit 96ea97a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2363      +/-   ##
==========================================
- Coverage   75.38%   70.03%   -5.36%     
==========================================
  Files         100      174      +74     
  Lines        8025    13027    +5002     
==========================================
+ Hits         6050     9123    +3073     
- Misses       1589     3299    +1710     
- Partials      386      605     +219     
Files Coverage Δ
ante/ante.go 66.66% <100.00%> (+18.45%) ⬆️
ante/fee.go 80.00% <100.00%> (+1.64%) ⬆️
ante/spam_prevention.go 75.92% <ø> (ø)
app/inflation/inflation.go 100.00% <100.00%> (ø)
app/upgradev3/migrations.go 84.21% <ø> (+5.94%) ⬆️
util/coin/utoken.go 100.00% <100.00%> (ø)
util/genmap/genmap.go 100.00% <100.00%> (ø)
util/ibc/ibc.go 58.82% <ø> (ø)
util/sdkutil/events.go 0.00% <ø> (ø)
util/store/iter.go 36.00% <ø> (-0.37%) ⬇️
... and 40 more

... and 114 files with indirect coverage changes

Copy link
Contributor

coderabbitai bot commented Jan 2, 2024

Walkthrough

The change introduces modifications in the BroadcastTx method of the Client type. It creates a copy of the ClientContext and updates the FromName and FromAddress fields of the copy using the values from r. It also assigns the result of txFactory.WithFromName(r.Name) to f and updates the BroadcastTx call to use cctx and f instead of *c.ClientContext and *c.txFactory.

Changes

File(s) Change Summary
sdkclient/tx/client.go Modified BroadcastTx method of Client type to create a copy of ClientContext, update fields, and use txFactory.WithFromName for f assignment

🐇✨
In the code's vast meadow, under the tech tree's shade,
A tiny upgrade hops in, no logic to evade.
With a leap and a bound to v0.47.7,
The rabbit declares, "Oh, this feels like heaven!"
🌟🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between cb45498 and 634b244.
Files ignored due to filter (2)
  • go.mod
  • go.sum
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • CHANGELOG.md

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 634b244 and be58427.
Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • sdkclient/tx/client.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • CHANGELOG.md

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between be58427 and dbaab9d.
Files selected for processing (1)
  • sdkclient/tx/client.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • sdkclient/tx/client.go

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between be58427 and a00d7da.
Files selected for processing (1)
  • sdkclient/tx/client.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • sdkclient/tx/client.go

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between a00d7da and 96ea97a.
Files selected for processing (1)
  • sdkclient/tx/client.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • sdkclient/tx/client.go

@robert-zaremba robert-zaremba added this pull request to the merge queue Jan 2, 2024
Merged via the queue into main with commit d6e83ee Jan 2, 2024
37 of 48 checks passed
@robert-zaremba robert-zaremba deleted the robert/bump-sdk branch January 2, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants