Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ugov module proto #2015

Merged
merged 6 commits into from
May 1, 2023
Merged

feat: ugov module proto #2015

merged 6 commits into from
May 1, 2023

Conversation

robert-zaremba
Copy link
Member

Description

New ugov module to manage umee / chain general parameters.
Notes:

  • I'm still not sure about the best name for the module. Please share your opinion here. Other options I was thinking about: x/chaingov or x/ext or x/umee or x/umeegov or x/ugov.
  • This module probably will be also used for emergency groups etc...

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba added the C:Core Core app features label May 1, 2023
@robert-zaremba robert-zaremba requested a review from a team as a code owner May 1, 2023 14:49
Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be we should call ugen (Umee General Params) instead of ugov

proto/umee/ugov/v1/tx.proto Outdated Show resolved Hide resolved
proto/umee/ugov/v1/tx.proto Outdated Show resolved Hide resolved
@toteki
Copy link
Member

toteki commented May 1, 2023

Left some comments

ugov seems like the best option out of the ones I've seen so far

robert-zaremba and others added 2 commits May 1, 2023 19:11
Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #2015 (2ea4fda) into main (7f05ad4) will decrease coverage by 7.06%.
The diff coverage is 44.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2015      +/-   ##
==========================================
- Coverage   75.38%   68.33%   -7.06%     
==========================================
  Files         100      118      +18     
  Lines        8025     9371    +1346     
==========================================
+ Hits         6050     6404     +354     
- Misses       1589     2488     +899     
- Partials      386      479      +93     
Impacted Files Coverage Δ
util/store/unmarshal.go 0.00% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/grpc_query.go 0.00% <0.00%> (ø)
x/incentive/keeper/hooks.go 0.00% <0.00%> (ø)
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/leverage/keeper/incentive.go 0.00% <0.00%> (ø)
x/oracle/keeper/hooks.go 95.65% <ø> (ø)
x/incentive/keeper/genesis.go 1.61% <1.61%> (ø)
x/incentive/genesis.go 10.32% <3.70%> (-3.01%) ⬇️
x/incentive/keeper/iter.go 20.14% <7.76%> (ø)
... and 28 more

... and 2 files with indirect coverage changes

@robert-zaremba robert-zaremba enabled auto-merge May 1, 2023 19:25
@robert-zaremba robert-zaremba added this pull request to the merge queue May 1, 2023
Merged via the queue into main with commit f5e1e42 May 1, 2023
@robert-zaremba robert-zaremba deleted the robert/ugov-proto branch May 1, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Core Core app features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants