Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add register token info base_denom #1867

Merged
merged 8 commits into from
Feb 23, 2023
Merged

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented Feb 22, 2023

Description

closes: #1866
Added get register token info by base_denom to cli and grpc web gateway


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@gsk967 gsk967 marked this pull request as ready for review February 22, 2023 17:57
@gsk967 gsk967 requested a review from a team as a code owner February 22, 2023 17:57
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #1867 (ecb6588) into main (3dee6cc) will increase coverage by 0.07%.
The diff coverage is 75.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1867      +/-   ##
==========================================
+ Coverage   56.07%   56.15%   +0.07%     
==========================================
  Files          93       93              
  Lines        8802     8840      +38     
==========================================
+ Hits         4936     4964      +28     
- Misses       3501     3511      +10     
  Partials      365      365              
Impacted Files Coverage Δ
x/leverage/types/query.pb.gw.go 0.00% <0.00%> (ø)
x/leverage/client/tests/tests.go 100.00% <100.00%> (ø)
x/leverage/keeper/grpc_query.go 67.21% <100.00%> (+0.43%) ⬆️

Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving

x/leverage/client/tests/tests.go Outdated Show resolved Hide resolved
@gsk967 gsk967 requested a review from a team as a code owner February 23, 2023 12:57
@gsk967 gsk967 enabled auto-merge February 23, 2023 13:26
@gsk967 gsk967 added this pull request to the merge queue Feb 23, 2023
Merged via the queue into main with commit b48c484 Feb 23, 2023
@gsk967 gsk967 deleted the sai/token_info_by_base_denom branch February 23, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add query to get the register token info on leverage
4 participants