Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mobile dvh and dashboard website header breaking #2841

Conversation

Cuzart
Copy link
Contributor

@Cuzart Cuzart commented Jul 14, 2024

This PR fixes some two style issues that appeared on mobile screen sizes.

The first thing is that the scroll container was set to a height of calc(100vh - 60px) which is the screen height minus the header height. For some browsers e.g. Safari on iOS this makes the whole page scrollable so you have two scroll containers and the header can be scrolled out of the viewport which is not wanted. I added another line that uses the dynamic virtual height dvh in addition to the fallback if the used browser does not support dvh.

The other issue was that the website header on the dashboard page was using display: grid and wrapped even when it was not needed. In addition there was a missing space underneath the button which looked a bit squeezed together.

Before:
IMG_0259

After this shows the fix: there is only one scroll container and the button in the website header is not breaking into the next line. Also there is some padding that makes the spacing more balanced.
IMG_0260

To replicate the issue just open the dashboard site on any mobile browser preferably one that supports dynamic heights like Safari.

Copy link

vercel bot commented Jul 14, 2024

@Cuzart is attempting to deploy a commit to the umami-software Team on Vercel.

A member of the Team first needs to authorize it.

@israelozarate7
Copy link
Contributor

PRs are usually made against the dev branch. You are doing it against the master branch directly, if I am not mistaken, despite it being the default branch you should change your PR against dev.

@Cuzart Cuzart changed the base branch from master to dev July 24, 2024 08:16
Copy link
Collaborator

@mikecao mikecao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikecao mikecao merged commit bcc712a into umami-software:dev Aug 5, 2024
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants