Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check_requirements() txt not found bug #11518

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 11, 2023

@AyushExel @kalenmike fixes "requirements.txt" not found warning.

πŸ€– Generated by Copilot at 2fd539a

Summary

πŸ›πŸ“πŸ› οΈ

Fixed a bug in check_requirements function that prevented it from finding the requirements.txt file in subdirectories. Changed the default path to use the current directory instead of the parent directory.

check_requirements
Fixes a bug in subdirs
Winter of errors

Walkthrough

  • Fix bug in check_requirements function to use current directory for requirements.txt file (link)

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Adjustment in the file path for checking YOLOv5 requirements.

πŸ“Š Key Changes

  • Modified the default path for requirements.txt from ROOT.parent / 'requirements.txt' to ROOT / 'requirements.txt'.

🎯 Purpose & Impact

  • πŸ› οΈ Fixes a potential issue where the requirements file was being referenced from the wrong directory.
  • πŸ‘Œ Ensures that dependency checks and auto-updates occur correctly, reducing installation errors.
  • πŸš€ Improves user experience by ensuring correct setup and smoother operation of the YOLOv5 software.

@AyushExel @kalenmike fixes "requirements.txt" not found warning.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher merged commit b72efd2 into master May 11, 2023
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-2 branch May 11, 2023 16:50
bandakopi pushed a commit to irajcode/yolov5 that referenced this pull request Jul 20, 2023
Fix check_requirements() txt not found bug

@AyushExel @kalenmike fixes "requirements.txt" not found warning.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant