Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deactivating #248

Open
wants to merge 1 commit into
base: feat/sagemaker-llms-dev
Choose a base branch
from
Open

Deactivating #248

wants to merge 1 commit into from

Conversation

joehearnshaw-6point6
Copy link

  • Deactivating the code to move logs to S3 buckets
  • Retaining the module functionality as it may be revived in future to help us get user data associated with the log (perhaps?) which can be used for log retrieval for ensuring we get latest logs specific to user-accounts

@joehearnshaw-6point6
Deactivating
3be9e70 
* Deactivating the code to move logs to S3 buckets
* Retaining the module functionality as it may be revived in future to help us get user data associated with the log (perhaps?) which can be used for log retrieval for ensuring we get latest logs specific to user-accounts
@joehearnshaw-6point6 joehearnshaw-6point6 requested a review from a team as a code owner February 14, 2025 16:08
aidanrussell
aidanrussell approved these changes Feb 19, 2025
View reviewed changes
Copy link

@aidanrussell aidanrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment is would prefer not to comment code out but simply delete it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanrussell aidanrussell aidanrussell approved these changes

Assignees

@aidanrussell aidanrussell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joehearnshaw-6point6 @aidanrussell