Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aventri code from frontend as replaced with Stova Events from Data Hub API #7537

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

DeanElliott96
Copy link
Contributor

@DeanElliott96 DeanElliott96 commented Feb 12, 2025

Description of change

Replaced by: #7502

Previously Aventri events and attendees were provided via a microservice. This has been replaced by Stova which is now ingested directly into Data Hub API and served via Data Hub API as well. These ingested events and attendees also behave like Data Hub Events and Data Hub attendees (contacts) according to the frontend.

On Data Hub API, Stova events and Attendees are converted to Data Hub Events and Contacts which means the frontend does not need to do all the data mangling it was previously doing.

Test instructions

Everything working as before as the aventri code being removed was not currently being used by the frontend.

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

…Data Hub API

Previously Aventri events and attendees were provided via a
microservice. This has been replaced by Stova which is now ingested
directly into Data Hub API and served via Data Hub API as well. These
ingested events and attendees also behave like Data Hub Events and Data
Hub atteendees (contacts).
@DeanElliott96 DeanElliott96 self-assigned this Feb 12, 2025
Copy link

cypress bot commented Feb 12, 2025

data-hub-frontend    Run #59237

Run Properties:  status check passed Passed #59237  •  git commit a320bacfab: Remove no longer required DataHubEvent
Project data-hub-frontend
Branch Review chore/TET-832-remove-old-aventri-code
Run status status check passed Passed #59237
Run duration 09m 23s
Commit git commit a320bacfab: Remove no longer required DataHubEvent
Committer Dean Elliott
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 4
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 74
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (43d9207) to head (a320bac).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7537      +/-   ##
==========================================
+ Coverage   88.57%   90.04%   +1.47%     
==========================================
  Files        1151     1123      -28     
  Lines       17826    17440     -386     
  Branches     5115     5029      -86     
==========================================
- Hits        15789    15704      -85     
+ Misses       2037     1736     -301     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DeanElliott96 DeanElliott96 marked this pull request as ready for review February 12, 2025 16:21
@DeanElliott96 DeanElliott96 requested a review from a team as a code owner February 12, 2025 16:21
Copy link
Contributor

@cgsunkel cgsunkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments

Copy link
Contributor

@dredmonds dredmonds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@DeanElliott96 DeanElliott96 merged commit 2a69bce into main Feb 14, 2025
16 checks passed
@DeanElliott96 DeanElliott96 deleted the chore/TET-832-remove-old-aventri-code branch February 14, 2025 11:43
chopkinsmade pushed a commit that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants