-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove aventri code from frontend as replaced with Stova Events from Data Hub API #7537
Conversation
…Data Hub API Previously Aventri events and attendees were provided via a microservice. This has been replaced by Stova which is now ingested directly into Data Hub API and served via Data Hub API as well. These ingested events and attendees also behave like Data Hub Events and Data Hub atteendees (contacts).
data-hub-frontend
|
Project |
data-hub-frontend
|
Branch Review |
chore/TET-832-remove-old-aventri-code
|
Run status |
|
Run duration | 09m 23s |
Commit |
|
Committer | Dean Elliott |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
4
|
|
0
|
|
74
|
View all changes introduced in this branch ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7537 +/- ##
==========================================
+ Coverage 88.57% 90.04% +1.47%
==========================================
Files 1151 1123 -28
Lines 17826 17440 -386
Branches 5115 5029 -86
==========================================
- Hits 15789 15704 -85
+ Misses 2037 1736 -301 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…ld-aventri-code generated from commit 2a69bce
Description of change
Replaced by: #7502
Previously Aventri events and attendees were provided via a microservice. This has been replaced by Stova which is now ingested directly into Data Hub API and served via Data Hub API as well. These ingested events and attendees also behave like Data Hub Events and Data Hub attendees (contacts) according to the frontend.
On Data Hub API, Stova events and Attendees are converted to Data Hub Events and Contacts which means the frontend does not need to do all the data mangling it was previously doing.
Test instructions
Everything working as before as the aventri code being removed was not currently being used by the frontend.
Checklist