Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/add-consent-field-to-contact-serializer #5923

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

chopkinsmade
Copy link
Contributor

@chopkinsmade chopkinsmade commented Jan 24, 2025

Description of change

Include the consent_data_last_modified field in the contact serializer for a GET request. This value is going to be displayed in the front end to users in an upcoming change

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.67%. Comparing base (7edbb44) to head (630300e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5923   +/-   ##
=======================================
  Coverage   96.67%   96.67%           
=======================================
  Files        1070     1070           
  Lines       25382    25382           
  Branches     1672     1672           
=======================================
  Hits        24538    24538           
  Misses        689      689           
  Partials      155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chopkinsmade chopkinsmade marked this pull request as ready for review January 24, 2025 13:15
@chopkinsmade chopkinsmade requested a review from a team as a code owner January 24, 2025 13:15
@chopkinsmade chopkinsmade merged commit 0c8bd2e into main Jan 27, 2025
7 checks passed
@chopkinsmade chopkinsmade deleted the feature/add-consent-field-to-contact-serializer branch January 27, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants