Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move prior calculation into the workers #275

Merged
merged 5 commits into from
Apr 27, 2016
Merged

Move prior calculation into the workers #275

merged 5 commits into from
Apr 27, 2016

Conversation

ujh
Copy link
Owner

@ujh ujh commented Apr 6, 2016 •
edited
Loading

The following things still need to be done:

  • Fix the tests
  • Write some new tests
  • Move the code from the match block in Engine#handle_response into separate methods
  • Do some profiling to figure out if sending all that data between the threads has a high overhead
  • Try running with expand_after set to 2 to see if this still works when the leafs aren't expanded right away (and compare to setting expand_after to 2 on the master branch)
  • Run the benchmarks!

@ujh
Copy link
Owner Author

ujh commented Apr 18, 2016

At least on 9x9 there's an issue when setting expand_after to 2. Something isn't quite right and it leads to 10% less wins. I will investigate and fix this before merging of course.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 94.521% when pulling bb499c0 on prior-calculation-in-the-workers into 41e306e on master.

@ujh ujh force-pushed the prior-calculation-in-the-workers branch from bb499c0 to 0815956 Compare April 23, 2016 18:00
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.06%) to 94.521% when pulling 0815956 on prior-calculation-in-the-workers into 40a7d03 on master.

ujh added 2 commits April 26, 2016 07:54
@ujh
Don't use all threads for the workers
0b28a09 
With the prior calculations in the workers it seems that reserving one
core for the master thread is important.
@ujh
Go back to cargo run now that it's working again
3c55833 
There was a bug with how cargo run handled stdin which terminated the
program right away. Now that it's fixed I can go back to using cargo run
instead of setting the direct path to the executable.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 94.713% when pulling 3c55833 on prior-calculation-in-the-workers into 40a7d03 on master.

@ujh ujh removed the wip label Apr 27, 2016
@ujh
Copy link
Owner Author

ujh commented Apr 27, 2016

Works fine now. I'll merge it like it is and move on.

@ujh ujh merged commit 7e5648c into master Apr 27, 2016
@ujh ujh deleted the prior-calculation-in-the-workers branch April 27, 2016 13:06
@ujh ujh mentioned this pull request Apr 27, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
performance refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ujh @coveralls