New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove UIRouterGlobals interface #3075 #31

Closed

christopherthielen opened this issue Jan 21, 2017 · 0 comments

Milestone

Member

christopherthielen commented Jan 21, 2017

Rename Globals class to UIRouterGlobals, then remove the interface.
Typescript can augment Classes, not just interfaces.

This allows easier injection of augmented globals (for example, for https://github.com/ui-router/rx)

The text was updated successfully, but these errors were encountered:

christopherthielen added this to the 4.0.0 milestone

christopherthielen mentioned this issue

core task: remove UIRouterGlobals interface angular-ui/ui-router#3075

Closed

christopherthielen closed this as completed in

thiago-sylvain mentioned this issue

Not work with last ui-router 1.0.18 tinusn/ui-router-metatags#29

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment