Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core task: remove UIRouterGlobals interface #3075

Closed
christopherthielen opened this issue Oct 7, 2016 · 2 comments
Closed

core task: remove UIRouterGlobals interface #3075

christopherthielen opened this issue Oct 7, 2016 · 2 comments
Labels
1.0

Comments

@christopherthielen
Copy link
Contributor

Rename Globals class to UIRouterGlobals, remove the interface.
Typescript can augment Classes, not just interfaces.
@christopherthielen
Copy link
Contributor Author

This will be a BREAKING CHANGE for those who inject Globals

@christopherthielen christopherthielen added this to the 1.0.0-final milestone Nov 7, 2016
@christopherthielen
Copy link
Contributor Author

Moving to ui-router/core#31

@christopherthielen christopherthielen modified the milestone: 1.0.0-final May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@christopherthielen