Refactor ForTestingController #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorWo
reviewed
Nov 12, 2024
src/main/java/edu/hawaii/its/groupings/controller/ErrorRestController.java
Outdated
Show resolved
Hide resolved
3af436c to
0d00498
Compare
JorWo
reviewed
Nov 26, 2024
src/main/java/edu/hawaii/its/groupings/controller/ErrorRestController.java
Outdated
Show resolved
Hide resolved
9a87872 to
d628f53
Compare
d628f53 to
ef8af2f
Compare
JorWo
reviewed
Dec 3, 2024
| } | ||
|
|
||
| @PreAuthorize("hasRole('ADMIN')") | ||
| @GetMapping(value = "/api/groupings/testing/exception") |
There was a problem hiding this comment.
Sorry final thing, could you change the URI to just /testing/exception? Make sure to update grouping.service.js throwException(). I think it's weird to have /api/groupings since we use this prefix for the GroupingsRestController.
ef8af2f to
bb536a8
Compare
JorWo
reviewed
Dec 5, 2024
src/test/java/edu/hawaii/its/groupings/controller/ErrorRestControllerTest.java
Outdated
Show resolved
Hide resolved
JorWo
reviewed
Dec 5, 2024
src/test/java/edu/hawaii/its/groupings/controller/ErrorRestControllerTest.java
Outdated
Show resolved
Hide resolved
bb536a8 to
431b857
Compare
JorWo
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link
1605
List of squashed commits
Test Checklist