Prevent departmental accounts from being added as admins #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorWo
reviewed
Sep 26, 2024
Comment on lines
246
to
255
| /** | ||
| * Helper - addAdmin | ||
| * Checks if the user is a departmental account | ||
| * @param {object} user - the user you are checking to see if they are a departmental account | ||
| * @returns {boolean} true if the user is a departmental account | ||
| */ | ||
| $scope.isDeptAccount = (user) => { | ||
| return (user['uid'] === user['uhUuid'] || user['uhUuid'] === ""); | ||
| } | ||
|
|
There was a problem hiding this comment.
This seems to be repeated code. Maybe move this function into general.controller.js? Then both grouping.controller.js and admin.controller.js have access to this function.
There was a problem hiding this comment.
And since this is an arrow function, you can drop the return:
$scope.isDeptAccount = (user) => (user['uid'] === user['uhUuid'] || user['uhUuid'] === "");
8669888 to
a55291f
Compare
michho8
pushed a commit
to michho8/uh-groupings-ui
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link
Groupings-1779
List of squashed commits
Test Checklist