Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed not allowed ids, updated users and updated the GroupingDescriptionTest #499

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Removed not allowed ids, updated users and updated the GroupingDescriptionTest #499

merged 1 commit into from
Oct 28, 2023

Conversation

mikhail-shkaralevich
Copy link
Contributor

@mikhail-shkaralevich mikhail-shkaralevich commented Oct 27, 2023 •
edited by JorWo
Loading

Ticket Link

Ticket-1216

Test Checklist

  • Exhibits Clear Code Structure:
  • Project Unit Tests Passed:
  • Project Integration Tests Passed:
  • Executes Expected Functionality:
  • Tested For Incorrect/Unexpected Inputs:

@mhodgesatuh
Copy link
Member

Added the two reviewers so that this PR can be processed.

JorWo
JorWo approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@JorWo JorWo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing uids from the grouper.test.properties files.

@JorWo JorWo changed the title Removed not allowed ids, updated users and updated the GroupingDescri… Removed not allowed ids, updated users and updated the GroupingDescriptionTest Oct 28, 2023
@JorWo JorWo merged commit ef063e3 into uhawaii-system-its-ti-iam:main Oct 28, 2023
JorWo pushed a commit to JorWo/uh-groupings-api that referenced this pull request Nov 19, 2023
@mikhail-shkaralevich @JorWo
removed not allowed ids, updated users and updated the GroupingDescri…
788120e 
…ptionTest (uhawaii-system-its-ti-iam#499)
@mikhail-shkaralevich mikhail-shkaralevich deleted the dev-misha-1216 branch July 29, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhodgesatuh mhodgesatuh mhodgesatuh approved these changes

@JorWo JorWo JorWo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikhail-shkaralevich @mhodgesatuh @JorWo