-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(v3.6.7) - Compability with Gymnasium 1.0.0 #456
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h, downgrade numpy from 2.1.1 to 1.26.4 for compability
…v1.0.0, some attributes consult updated with get_wrapper_attr too
…d of tuples (avoid gymnasium warnings)
… default in new versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update allows direct compatibility with the latest release of Gymnasium v1.0.0.
This version requires changes for compatibility with the other modules that generate optional or mandatory dependencies with Sinergym. Especially, Stable Baselines 3 and numpy, which is already handled correctly when installing the tool.
As Stable Baselines 3 already implements its synchronization with this version, but has not yet released, the main branch will be used directly. In future versions of Synergym, it will be modified when a release is created.
The new stable version of Gymnasium requires changes in some specifications. Some imports have been adapted, and the attribute query has been updated to avoid errors.
This update includes some additional enhancements, such as implementation improvement tasks and refinement to fix/debug warnings that have been appearing in the tool. For more details on these additional enhancements, check the changelog for a complete list.
Types of changes
Checklist:
autopep8
second level aggressive.isort
.cd docs && make spelling && make html
pass (required if documentation has been updated.)pytest tests/ -vv
pass. (required).pytype -d import-error sinergym/
pass. (required)Changelog: