(v3.5.2) SB3 Logger bug fix with wandb #429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a minor issue with the SB3 logger to record data in the same location as the WandB session for our environments.
Motivation and Context
In algorithms like PPO, there is no problem since the step counter aligns with those of the environment. However, in other algorithms like SAC, some synchronization mismatches can occur between the algorithm's steps and the actual steps taken in the environment, which caused the data not to be logged in the latter case.
This PR fixes the issue by ensuring that logs to WandB made from the native SB3 logger do not cause an increment in the number of steps, and therefore in the X-axis of the graphs.
Why is this change required? What problem does it solve? Please, reference issue or issues opened previously.
Fixes #(issue or issues)
Types of changes
Checklist:
autopep8
second level aggressive.isort
.cd docs && make spelling && make html
pass (required if documentation has been updated.)pytest tests/ -vv
pass. (required).pytype -d import-error sinergym/
pass. (required)Changelog: