Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v2.5.0) - Energyplus v23.1.0 compability #343

Merged
merged 15 commits into from
Jun 1, 2023
Merged

Conversation

AlejandroCN7
Copy link
Member

@AlejandroCN7 AlejandroCN7 commented Jun 1, 2023

Description

Compatibility with the latest stable release of Energyplus engine (v23.1.0) is integrated in this PR.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Why is this change required? What problem does it solve? Please, reference issue or issues opened previously.

Fixes #338

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

Additional information:

The integration of epJSON format (v2.4.0), together the last Energyplus engine (v2.5.0), It results in a substantial performance improvement in the simulations performed in Sinergym for each of the buildings, with 3 random control episodes in each of them, as shown below:

Sinergym v2.5.0 --> It works with epJSON and Energyplus v23.1.0

====================================================
TIMES RECORDED IN ENVIRONMENTS WITH  3  EPISODE(S):
====================================================
Eplus-5Zone-mixed-continuous-stochastic-v1        : 12.638641 SECONDS
Eplus-datacenter-mixed-continuous-stochastic-v1   : 36.603867 SECONDS
Eplus-office-mixed-continuous-stochastic-v1       : 34.577541 SECONDS
Eplus-warehouse-mixed-continuous-stochastic-v1    : 28.246721 SECONDS
Eplus-officegrid-mixed-continuous-stochastic-v1   : 63.88138 SECONDS
Eplus-shop-mixed-continuous-stochastic-v1         : 15.999817 SECONDS

Sinergym v2.3.4 --> It works with IDF and Energyplus v9.5.0

====================================================
TIMES RECORDED IN ENVIRONMENTS WITH  3  EPISODE(S):
====================================================
Eplus-5Zone-mixed-continuous-stochastic-v1        : 15.571579 SECONDS
Eplus-datacenter-mixed-continuous-stochastic-v1   : 41.227278 SECONDS
Eplus-office-mixed-continuous-stochastic-v1       : 54.140775 SECONDS
Eplus-warehouse-mixed-continuous-stochastic-v1    : 62.405299 SECONDS
Eplus-officegrid-mixed-continuous-stochastic-v1   : 71.349725 SECONDS
Eplus-shop-mixed-continuous-stochastic-v1         : 21.038502 SECONDS

Changelog:

  • Update Dockerfile and devcontainer to install the latest EnergyPlus release automatically.
  • Update all buildings to this new version (some names have changed lightly). Adaptation has been done using Energyplus IDF updater and downloading the updated building's, then we have combined them and make some changes in order to improve/solve some aspects.
  • Update RDD files in order to adapt the new possible observation space configurable by Sinergym.
  • Fixed default observation space for 5ZoneAutoDXVAV.epJSON (due to observation space update mentioned before).
  • Fixed bug in check_run_times.py bug.
  • Updated version compatibility table in INSTALL.md and docs.
  • Deleted unusued path in gitignore.
  • Deleted out-dated comment in Dockerfile and deleted IDF extension from devcontainer.
  • Fixed some idf name to building (more generic than epJSON name) in modeling (source and tests).
  • Fixed code example in tests/README.md.
  • Fixed tests which were using 5ZoneAutoDXVAV.epJSON building model, due to the fact that some of its default values have changed.

@AlejandroCN7 AlejandroCN7 marked this pull request as ready for review June 1, 2023 13:42
@AlejandroCN7 AlejandroCN7 merged commit afe190d into main Jun 1, 2023
@AlejandroCN7 AlejandroCN7 deleted the feat/issue-338 branch June 1, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Update Energyplus version with the latests available stable release.
1 participant