Changed the member initialization and some names of CFiniteElementVec #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f9a946c to
2e12599
Compare
2e12599 to
b8ba60e
Compare
norihiro-w
reviewed
Jun 17, 2018
|
|
||
| CFiniteElementVec::CFiniteElementVec(process::CRFProcessDeformation* dm_pcs, | ||
| const int C_Sys_Flad, const int order) | ||
| : CElement(C_Sys_Flad, order), pcs(dm_pcs), h_pcs(NULL), t_pcs(NULL), excavation(false), |
There was a problem hiding this comment.
why have you moved all the allocation/initialization here? if a member variable is a pointer, there is no advantage to initialize them here.
There was a problem hiding this comment.
Thanks @norihiro-w . Only for a little performance but it really looks ugly and make debug difficulty with such long initialization list. Just moved most of the pointer members from the initialization list to the constructor body.
09fb0ec to
cd634c0
Compare
…t to the constructor body
cd634c0 to
f1ea446
Compare
|
looks good for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as titled.
The next PR will be for some improvements in the coupling computation of H and M.