-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing benchmarks #6
Conversation
@bilke This commit fixes five benchmarks. The problem in SY_RWPT is that the result files with the name extension of |
I will have a look.. |
c0b7604
to
0725c04
Compare
@bilke The vtk files of SY_RWPT are for particles. Maybe the file name extension of vtk is missing in cmake comparison function. |
@wenqing Maybe this works:
See Christophs PR for details. |
@bilke It works with your suggestion. Thanks. |
YS-RWPT fixed. |
2a156a0
to
e943f57
Compare
@WaltherM Could you please check the results of
The two benchmarks run but their results need to be confirmed. |
e943f57
to
c583fb4
Compare
I'm taking a look... @wenqing both benchmarks produce the same results for me. I used the latest develop version from the old, internal repo vs this new one. |
There are several benchmarks failed with the open source code of ogs5. This PR is aimed to fix the failed benchmarks that are listed below:
Those need freeqc