Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing benchmarks #6

Merged
merged 2 commits into from
Apr 27, 2016
Merged

Fixing benchmarks #6

merged 2 commits into from
Apr 27, 2016

Conversation

wenqing
Copy link
Member

@wenqing wenqing commented Feb 11, 2016

There are several benchmarks failed with the open source code of ogs5. This PR is aimed to fix the failed benchmarks that are listed below:

  • AKS-H_us/RSM/AT_5 (Failed)
  • BG-ECLIPSE_DUMUX/kinetic_CO2phase_generation_E100/CO2phase_gen_E100 (Failed)
  • BG-ECLIPSE_DUMUX/kinetic_CO2phase_generation_E300/CO2phase_gen_E300 (Failed)
  • JOD-OVERLAND_FLOW/gian_quad (Failed)
  • MW-DENSITY-DEPENDENT_FLOW/goswami-clement/constrBC_PressAsHead_tri/HM (Failed)
  • MW-DENSITY-DEPENDENT_FLOW/goswami-clement/wholeBC_PressAsHead_tri/HM (Failed)
  • UJG-HM/hm_cc_tri_s (Failed)
  • UJG-M/creep/m_crp_tri (Failed)
  • UJG-HM/hm_foot_tet (Failed)
  • YS-RWPT/Harter/colloid_t (Failed)
  • YS-RWPT/3DGrain/3d_grain (Failed)
  • YS-RWPT/HomoCube/3DRWPTCubTet (Failed)
  • YS-RWPT/Forchheimer/forchheimer_rwpt (Failed)

Those need freeqc

  • BG-C/2d_Cl_transport_Clay/Nuklidtransport (Failed)
  • CB-C/Engesgaard/Kin/slow_kin_pqc/pds (Failed)
  • CB-C/Engesgaard/Kin/slow_kin_pqc_krc/pds (Failed)
  • CB-C/NAPL-dissolution/1D_NAPL-diss_flow/lin/1D_TPF_resS_flow (Failed)

@wenqing
Copy link
Member Author

wenqing commented Feb 11, 2016

@bilke This commit fixes five benchmarks. The problem in SY_RWPT is that the result files with the name extension of .particles.vtk are not saved in the building directory but in the directory of their input data. Would you please check this? The mentioned file name is declared here:
https://github.com/wenqing/ogs5/blob/fix_benchmarks/FEM/rf_random_walk.cpp#L6128

@bilke
Copy link
Member

bilke commented Feb 12, 2016

I will have a look..

@wenqing
Copy link
Member Author

wenqing commented Feb 12, 2016

@bilke The vtk files of SY_RWPT are for particles. Maybe the file name extension of vtk is missing in cmake comparison function.

@bilke
Copy link
Member

bilke commented Feb 12, 2016

@wenqing Maybe this works:

string vtk_file_name = pathJoin(defaultOutputPath, FileName);

See Christophs PR for details.

@wenqing
Copy link
Member Author

wenqing commented Feb 12, 2016

@bilke It works with your suggestion. Thanks.

@wenqing
Copy link
Member Author

wenqing commented Feb 12, 2016

YS-RWPT fixed.

@wenqing
Copy link
Member Author

wenqing commented Feb 12, 2016

@WaltherM Could you please check the results of

  • MW-DENSITY-DEPENDENT_FLOW/goswami-clement/constrBC_PressAsHead_tri/HM (Failed)
  • MW-DENSITY-DEPENDENT_FLOW/goswami-clement/wholeBC_PressAsHead_tri/HM (Failed)
    ?

The two benchmarks run but their results need to be confirmed.
The source code is in
https://github.com/ufz/ogs5
and the input data can be fetched from
https://github.com/ufz/ogs5-benchmarks

@hydromarc
Copy link

I'm taking a look...

@wenqing both benchmarks produce the same results for me. I used the latest develop version from the old, internal repo vs this new one.

@wenqing wenqing merged commit 8848215 into ufz:master Apr 27, 2016
@wenqing wenqing deleted the fix_benchmarks branch March 21, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants