fix BENCHMARK_DIR not used #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -1,4 +1,4 @@ | |||
| set(BENCHMARK_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR}/benchmarks/${benchmarkDir}) | |||
| set(BENCHMARK_OUTPUT_DIRECTORY ${BENCHMARK_DIR}/${benchmarkDir}) | |||
There was a problem hiding this comment.
The intention here is to have benchmark output files just in the build-directory to keep the source dir in a clean state. This is especially helpful in Jenkins to have a build and benchmark run in one enclosed directory.
So I suggest to either revert this change or introduce another variable (e.g. BENCHMARK_OUTPUT_DIR). ✅
There was a problem hiding this comment.
i see. then i will revert this change. is it still ok if I keep the change at line 50?
|
reverted the change and keep the behavior that benchmark outputs are generated under build directories. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix an issue that benchmarking with the user provided BENCHMARK_DIR is not working