Improvement in the creen output #134

wenqing · 2019-02-04T08:26:12Z

[Display.h/cpp] Removed some unused function. 176ad8f
[Display.h/cpp] Give a namespace for the functions. 93dcbb3
Only allow one rank to call ScreenMessage under MPI. 6311af5
Replaced frequently called std::cout with ScreenMessage to suppress screen output under MPI. 3d6b1b8

…og in MPI

norihiro-w · 2019-02-04T12:28:47Z

Base/display.cpp

@@ -28,6 +28,8 @@
 extern FILE* OpenMsgFile(void);
 extern void CloseMsgFile(FILE*);

+namespace Display


i am not sure what is a reason for this new namespace. It makes the code longer.

Just to remove extern. If you feel it makes longer, I can add 'use namespace Display' and remove the namespace name in cpp files.

removed Display:: in the most of places where it appears.

see commit: 66c4b24

norihiro-w · 2019-02-05T02:32:42Z

👍

wenqing added 3 commits February 1, 2019 10:16

[Display.h/cpp] Removed some unused function

176ad8f

[Display.h/cpp] Give a namespace for the functions.

93dcbb3

Only allow one rank to call ScreenMessage under MPI

6311af5

wenqing force-pushed the screen_output branch from 3d6b1b8 to 7194971 Compare February 4, 2019 10:00

Replaced frequently called std::cout with ScreenMessage to suppress l…

db8fa46

…og in MPI

wenqing force-pushed the screen_output branch from 7194971 to db8fa46 Compare February 4, 2019 10:20

norihiro-w reviewed Feb 4, 2019

View reviewed changes

wenqing force-pushed the screen_output branch from 66c4b24 to 77831ee Compare February 4, 2019 15:35

Avoid to show namespace of Display

a08adb4

wenqing force-pushed the screen_output branch from 77831ee to a08adb4 Compare February 4, 2019 16:02

wenqing merged commit e61a9ad into ufz:master Feb 5, 2019

Provide feedback