Changed the term of LiquidFlow for time unit scaling factor #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds interesting and the corresponding benchmark looks interesting too. Would this fix make Neumann boundary conditions to work if defined CONSTANT_NEUMANN in .st files not in .bc with consistent $TIME_UNIT? |
|
@nbeyond This is only for LiquidFlow, which is only process that the time unit factor is applied to the mass term. The changes only influence the Neumann condition of source term of LiquidFlow. Without this change, the time unit in Neumann condition of source term of LiquidFlow is always "s" for whichever time unit is defined in tim file. |
|
it looks good for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For LiquidFlow, this PR moves the time unit scaling factor from the mass term to the Jacobian term. With this change, the time unit in the source term of LiquidFlow has to be consistency with the time unit defined in tim file. Accordingly, the NeumannBC value of one benchmark was changed (ufz/ogs5-benchmarks#19).
This PR also fixes the fluid property output and a compilation warning.