$EPSILON in the bc-file can replace the automatically calculated search length #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e initialized with -1, which means it is not active and activated via Keyword in the bc file.
…or the 2units2faults problem
…or the 2units2faults problem
|
I will debug based on 2units2faults_FCT, hm1_1Dbeam, tm1_3Dorigin.numdiff. |
… change the input files of the benchmarks
|
@wenqing : I think this can be merged now. We will need the same for source terms - Will be the next Pull Request |
…then this should be done during the construct grid procedure an not in inside the search function.
wenqing
reviewed
Jul 31, 2018
| @@ -1378,7 +1378,12 @@ void CBoundaryConditionsGroup::Set(CRFProcess* pcs, int ShiftInNodeVector, const | |||
| // debug_out.close(); | |||
| //#endif | |||
| std::vector<size_t> msh_nod_vec; | |||
| double computed_search_length = m_msh->getSearchLength(); | |||
| if (bc->epsilon != -1) | |||
There was a problem hiding this comment.
It is better to use epsilon from gli. We can take a look together once you are back.
There was a problem hiding this comment.
@norihiro-w : @Thomas-TK explained me the reason why to use this BC tolerance: to allow different processes have different regions of nodes for BCs. I think it looks good. Do you have any comment?
There was a problem hiding this comment.
no i have no further comments. i will merge this
wenqing
approved these changes
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making use of $EPSILON in the bc-file for boundary conditions. Should be initialized with -1, which means it is not active and can be activated via the keyword in the bc file.