VTP + PVD output for particles if output option is set as PVD #106
Conversation
|
I will have a look at the benchmarks ! |
|
The failing benchmarks use PVD as output option and therefore no VTKs are written anymore. PVD and VTPs instead. Benchmarks must be updated. |
FEM/problem.cpp
Outdated
| else | ||
| DATWriteParticleFile(0); | ||
| } | ||
| else | ||
| DATWriteParticleFile(0); // YS |
There was a problem hiding this comment.
can you add an indent here?
|
i have only one tiny comment. 👍 if the benchmark is green |
There was a problem hiding this comment.
Ctest configuration in the YS.cmake has to be updated with the new output file names:
https://github.com/Thomas-TK/ogs5/blob/master/scripts/cmake/benchmarks/YS.cmake
|
@Thomas-TK Yes Wenginq is correct, change this line: https://github.com/ufz/ogs5/blob/master/scripts/cmake/benchmarks/YS.cmake#L24 |
|
Thank you |
|
@norihiro-w Now the failed benchmarks are those THM related due to the merging of ufz/ogs5-benchmarks_ref#24. Therefore, I merged this PR. I will revised PR #105 soon. |
No description provided.