initialize ice fluxes and add "tiice" array. stochastic_physics #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
requested changes
May 20, 2020
There was a problem hiding this comment.
I am fine with the stochastic_physics PR, but the fv3atm PR - aside from the question whether we accept changes to IPD or not - has some issues: (1) the newly introduced ice temperature doesn't get used anywhere in the physics, it is just added and read in/written out (2) there is no submodule pointer update for the ccpp-physics PR. @shansun6
climbfuji
approved these changes
May 27, 2020
junwang-noaa
approved these changes
May 27, 2020
XiaSun-Atmos
pushed a commit
to XiaSun-Atmos/ufs-weather-model
that referenced
this pull request
Aug 8, 2020
* physics update from GFS.v16.0.4 * GFS.v16.0.4 physics udpate * remove whitespaces in sfc_diff.f * keep z0 unchanged in coupled mode in sfc_diff.f * fix IPD run * point to NCAR ccpp-physics branch Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com>
LarissaReames-NOAA
pushed a commit
to LarissaReames-NOAA/ufs-weather-model
that referenced
this pull request
Oct 22, 2021
* Removing use of mpp_io_mod and fms_io_mod from the dycore code. Replacing the necessary functions with fms2_io_mod functions
* Adding a call to set_filename_appendix so that nest is added to filename when needed and removing unneccessary code in fv_io_mod
* FV3 Documentation - formatted PDF and source files for FV3 documentation.
* Documentation and defaults changes
- Updated defaults for hord options to use 8 and 10, and removal of mention of hord = 9 (experimental, unsupported) scheme.
* Initialize {sw,se,nw,ne}_corner to .false in model/fv_arrays.F90
(cherry picked from commit bf0630f)
* merge of latest dev work from GFDL Weather and Climate Dynamics Division (ufs-community#114)
* read ak/bk from user specified files (ufs-community#115)
* add input.nml parameter fv_eta_file for user specified ak/bk; change ks calculation when npz_type=input; use newunit to replace fixed file unit for npz_type=input
(cherry picked from commit 3a0d35a)
* FV3 Example Notebooks and cleanup of docs directory (ufs-community#117)
* removed module use of INPUT_STR_LENGTH in fv_control.F90 (ufs-community#122)
* add check on eta levels to ensure their monotonicity
* update Jili Dong's ak/bk external input to
- use the FMS ascii_read (single read/broadcast)
- error check input to ensure the proper number of levels present
* added a format description for the external eta file and ensured a correct the file length check for FMS 2021.03 and greater
* merge of minor updates from GFDL Weather and Climate Dynamics Division (20210804) (ufs-community#127)
Co-authored-by: Lauren Chilutti <Lauren.Chilutti@noaa.gov>
Co-authored-by: laurenchilutti <60401591+laurenchilutti@users.noreply.github.com>
Co-authored-by: lharris4 <53020884+lharris4@users.noreply.github.com>
Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
Co-authored-by: Jili Dong <jili.dong@noaa.gov>
SamuelTrahanNOAA
referenced
this pull request
in SamuelTrahanNOAA/ufs-weather-model
Apr 9, 2022
* Updated submodules for Bug fixes to drag_suite.F90 and GFS_surface_composites.F90 * Included Reg test results for Bug fixes to drag_suite.F90 and GFS_surface_composites.F90 * re-enable cpld_debug_p8 * re-enable cpld_debug_p8 for gnu * Hera intel tests passed. * Hera gnu tests passed. * Jet intel tests passed. (The cpld_restart_c384_p8 initially failed due to filesystem issues and had to be rerun. This was unrelated to the code. It appeared to be a dropped filesystem mount.) * Point to RRFS_dev for FV3
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
- Modify Externals.cfg to use head of NCAR/UFS_UTILS dtc/develop branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated PRs:
FV3: NOAA-EMC/fv3atm#119
stochastic_physics: NOAA-PSL/stochastic_physics#23