Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to aerosol RTs - new dust and fcsav #1170

Merged
merged 47 commits into from
May 19, 2022
Merged
Show file tree
Hide file tree
Changes from 46 commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
1d390b5
Update AERO_ExtData.rc for new fengsha dust input
bbakernoaa Apr 6, 2022
63db579
Update alpha to be consistent with latest scaling
bbakernoaa Apr 6, 2022
e8ef421
Merge branch 'ufs-community:develop' into develop
bbakernoaa Apr 9, 2022
98a8780
fix: add FSCAV_AERO for regression tests
bbakernoaa Apr 11, 2022
7d17cb7
Merge branch 'ufs-community:develop' into develop
bbakernoaa Apr 12, 2022
f1ab9da
Update cpld_control_p8
bbakernoaa Apr 12, 2022
6be35ed
add FSCAV_AERO to default coupled RT variables
bbakernoaa Apr 13, 2022
45f4f99
This was rolled back because it is now in default_vars.sh
bbakernoaa Apr 13, 2022
2df8f42
rolled back
bbakernoaa Apr 13, 2022
9be0d61
Update cpld_control_c192_p8
bbakernoaa May 6, 2022
ff647b7
Update cpld_control_c384_p8
bbakernoaa May 6, 2022
54af806
Update cpld_control_c96_p8
bbakernoaa May 6, 2022
d85d71a
Update cpld_control_p8
bbakernoaa May 6, 2022
f96d43d
Update cpld_debug_p8
bbakernoaa May 6, 2022
9765e0c
Update cpld_mpi_p8
bbakernoaa May 6, 2022
2114229
Update cpld_decomp_p8
bbakernoaa May 6, 2022
63d9c09
Update cpld_restart_c192_p8
bbakernoaa May 6, 2022
4826456
Update cpld_restart_c384_p8
bbakernoaa May 6, 2022
d89b1af
Update cpld_restart_c96_p8
bbakernoaa May 6, 2022
ee05082
Merge branch 'ufs-community:develop' into develop
bbakernoaa May 11, 2022
8588c75
Fix: Cleanup files
bbakernoaa May 11, 2022
b302d57
update the line to not copy rc files when CPLCHM is true
bbakernoaa May 11, 2022
04e3773
added the correct path for INPUTDATA_ROOT/GOCART/p8/ExtData
bbakernoaa May 12, 2022
cc9160b
adding tavg_cmass to output files
bbakernoaa May 12, 2022
60d8750
Reverting/removing tavg_cmass
bbakernoaa May 12, 2022
2e77acc
removing several test files for aerosols
bbakernoaa May 12, 2022
fdef213
change of BL_DATE in rt.sh
bbakernoaa May 12, 2022
0f36755
update
bbakernoaa May 12, 2022
ccfb273
[AutoRT] hera.gnu Job Completed.
BrianCurtis-NOAA May 12, 2022
0cbcfc8
Read the correct variable from the drag partition file
bbakernoaa May 13, 2022
bcdb7fd
Merge branch 'develop' of https://github.com/bbakernoaa/ufs-weather-m…
bbakernoaa May 13, 2022
4b73284
Adding correct Refresh time in drag partition
bbakernoaa May 13, 2022
51a4d6e
Update BL_DATE= 20220517
bbakernoaa May 17, 2022
73062ee
Update to the latest UFS
bbakernoaa May 17, 2022
f37c38b
[AutoRT] hera.intel Job Completed.
BrianCurtis-NOAA May 17, 2022
745c5d3
Add wcoss cray RT log: all tests passed
MinsukJi-NOAA May 17, 2022
afc526e
[AutoRT] hera.gnu Job Completed.
BrianCurtis-NOAA May 17, 2022
e81cb28
[AutoRT] orion.intel Job Completed.
BrianCurtis-NOAA May 17, 2022
b4214c4
[AutoRT] cheyenne.gnu Job Completed.
BrianCurtis-NOAA May 18, 2022
26717e7
Add wcoss dell RT log: all tests passed
MinsukJi-NOAA May 18, 2022
f6a0e5b
[AutoRT] gaea.intel Job Completed.
BrianCurtis-NOAA May 18, 2022
a3da492
[AutoRT] jet.intel Job Completed.
BrianCurtis-NOAA May 18, 2022
0c1d249
update cpld c96 resources on cheyenne
DeniseWorthen May 18, 2022
debd75d
[AutoRT] cheyenne.gnu Job Completed.
BrianCurtis-NOAA May 18, 2022
4ed3fe0
fix block size error for cpld_mpi_p8 on cheyenne
DeniseWorthen May 18, 2022
c7e17e7
add cheyenne.intel log
DeniseWorthen May 19, 2022
eb249b9
Revert ROCOTO changes in rt.sh
MinsukJi-NOAA May 19, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
408 changes: 212 additions & 196 deletions tests/RegressionTests_cheyenne.gnu.log

Large diffs are not rendered by default.

1,183 changes: 596 additions & 587 deletions tests/RegressionTests_cheyenne.intel.log

Large diffs are not rendered by default.

1,358 changes: 680 additions & 678 deletions tests/RegressionTests_gaea.intel.log

Large diffs are not rendered by default.

324 changes: 162 additions & 162 deletions tests/RegressionTests_hera.gnu.log

Large diffs are not rendered by default.

1,063 changes: 530 additions & 533 deletions tests/RegressionTests_hera.intel.log

Large diffs are not rendered by default.

928 changes: 458 additions & 470 deletions tests/RegressionTests_jet.intel.log

Large diffs are not rendered by default.

1,363 changes: 688 additions & 675 deletions tests/RegressionTests_orion.intel.log

Large diffs are not rendered by default.

883 changes: 436 additions & 447 deletions tests/RegressionTests_wcoss_cray.log

Large diffs are not rendered by default.

1,296 changes: 597 additions & 699 deletions tests/RegressionTests_wcoss_dell_p3.log

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions tests/default_vars.sh
Original file line number Diff line number Diff line change
Expand Up @@ -567,34 +567,34 @@ elif [[ $MACHINE_ID = cheyenne.* ]]; then
INPES_cpl_atmw_gdas=6; JNPES_cpl_atmw_gdas=8; WPG_cpl_atmw_gdas=24
WAV_tasks_atmw_gdas=264

TASKS_cpl_c96=192; THRD_cpl_c96=1
INPES_cpl_c96=3; JNPES_cpl_c96=8; WPG_cpl_c96=6
OCN_tasks_cpl_c96=30
ICE_tasks_cpl_c96=12
TASKS_cpl_c96=324; THRD_cpl_c96=1
INPES_cpl_c96=6; JNPES_cpl_c96=8; WPG_cpl_c96=6
OCN_tasks_cpl_c96=20
ICE_tasks_cpl_c96=10

TASKS_cpl_dflt=200; THRD_cpl_dflt=1
INPES_cpl_dflt=3; JNPES_cpl_dflt=8; WPG_cpl_dflt=6
TASKS_cpl_dflt=344; THRD_cpl_dflt=1
INPES_cpl_dflt=6; JNPES_cpl_dflt=8; WPG_cpl_dflt=6
OCN_tasks_cpl_dflt=20
ICE_tasks_cpl_dflt=10
WAV_tasks_cpl_dflt=20

TASKS_cpl_thrd=120; THRD_cpl_thrd=2
INPES_cpl_thrd=3; JNPES_cpl_thrd=4; WPG_cpl_thrd=6
TASKS_cpl_thrd=200; THRD_cpl_thrd=2
INPES_cpl_thrd=6; JNPES_cpl_thrd=4; WPG_cpl_thrd=6
OCN_tasks_cpl_thrd=20
ICE_tasks_cpl_thrd=10
WAV_tasks_cpl_thrd=12
WAV_tasks_cpl_thrd=20

TASKS_cpl_dcmp=200; THRD_cpl_dcmp=1
INPES_cpl_dcmp=4; JNPES_cpl_dcmp=6; WPG_cpl_dcmp=6
TASKS_cpl_dcmp=344; THRD_cpl_dcmp=1
INPES_cpl_dcmp=4; JNPES_cpl_dcmp=12; WPG_cpl_dcmp=6
OCN_tasks_cpl_dcmp=20
ICE_tasks_cpl_dcmp=10
WAV_tasks_cpl_dcmp=20

TASKS_cpl_mpi=280; THRD_cpl_mpi=1
INPES_cpl_mpi=4; JNPES_cpl_mpi=8; WPG_cpl_mpi=6
OCN_tasks_cpl_mpi=34
ICE_tasks_cpl_mpi=20
WAV_tasks_cpl_mpi=28
TASKS_cpl_mpi=498; THRD_cpl_mpi=1
INPES_cpl_mpi=6; JNPES_cpl_mpi=12; WPG_cpl_mpi=6
OCN_tasks_cpl_mpi=24
ICE_tasks_cpl_mpi=12
WAV_tasks_cpl_mpi=24

TASKS_cpl_c384=728; THRD_cpl_c384=3
INPES_cpl_c384=8; JNPES_cpl_c384=12; WPG_cpl_c384=24
Expand Down Expand Up @@ -929,7 +929,7 @@ export RANDOM_CLDS=.false.
export CNVCLD=.true.

# Aerosol convective scavenging
export FSCAV_AERO="'*:0.0'"
export FSCAV_AERO='"*:0.3","so2:0.0","msa:0.0","dms:0.0","nh3:0.4","nh4:0.6","bc1:0.6","bc2:0.6","dust1:0.6","dust2:0.6","dust3:0.6","dust4:0.6","dust5:0.6","seas1:0.5","seas2:0.5","seas3:0.5","seas4:0.5","seas5:0.5"'

# SFC
export DO_MYJSFC=.false.
Expand Down Expand Up @@ -1248,7 +1248,6 @@ export DO_SAT_ADJ=.false.
# P7 default mushy thermo
export KTHERM=2
export TFREEZE_OPTION=mushy

export CPLFLX=.true.
export CPLICE=.true.
export CPL=.true.
Expand Down Expand Up @@ -1336,6 +1335,7 @@ export HAFS=false
export DATM_CDEPS=true
export DOCN_CDEPS=false
export CPLWAV=.false.
export CPLCHM=.false.
export DAYS=1
export FHMAX=24
export FHROT=0
Expand Down
2 changes: 1 addition & 1 deletion tests/fv3_conf/control_run.IN
Original file line number Diff line number Diff line change
Expand Up @@ -132,5 +132,5 @@ fi
#prognostic aerosols
if [ $CPLCHM = .true. ]; then
cp ${PATHRT}/parm/gocart/*.rc .
ln -sf @[INPUTDATA_ROOT]/GOCART/ExtData .
ln -sf @[INPUTDATA_ROOT]/GOCART/p8/ExtData .
fi
1 change: 0 additions & 1 deletion tests/fv3_conf/cpld_control_run.IN
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,5 @@ fi

#prognostic aerosols
if [ $CPLCHM = .true. ]; then
cp @[INPUTDATA_ROOT]/GOCART/p8/rc/*.rc .
ln -sf @[INPUTDATA_ROOT]/GOCART/p8/ExtData .
fi
5 changes: 3 additions & 2 deletions tests/parm/gocart/AERO.rc
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
NX: 4
NY: 24
NX: 4
NY: 24

# Atmospheric Model Configuration Parameters
# ------------------------------------------
IOSERVER_NODES: 0
Expand Down
176 changes: 73 additions & 103 deletions tests/parm/gocart/AERO_ExtData.rc

Large diffs are not rendered by default.

106 changes: 63 additions & 43 deletions tests/parm/gocart/AERO_HISTORY.rc
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,22 @@ EXPSRC: GEOSgcm-v10.16.0


COLLECTIONS: 'inst_aod'
'tavg_cmass'
# 'inst_du_ss'
# 'inst_ca'
# 'inst_ni'
# 'inst_su'
# 'inst_du_bin'
# 'inst_ss_bin'
# 'inst_ca_bin'
# 'inst_ni_bin'
# 'inst_su_bin'
# 'inst_2d'
# 'inst_3d'
# 'inst_aod'
# 'tavg_du_ss'
# 'tavg_du_bin'
# 'tavg_2d_rad'
# 'tavg_3d_rad'
::

##################################################
Expand Down Expand Up @@ -43,20 +58,34 @@ PC720x361-DC.LM: 72
inst_du_ss.mode: 'instantaneous',
inst_du_ss.grid_label: PC720x361-DC ,
inst_du_ss.splitField: 1,
inst_du_ss.frequency: 010000 ,
inst_du_ss.frequency: 120000 ,
inst_du_ss.duration: 010000 ,
inst_du_ss.ref_time: 000000 ,
inst_du_ss.nbits: 10,
inst_du_ss.fields: 'DU' , 'DU' ,
'SS' , 'SS' ,
::

tavg_du_ss.format: 'CFIO' ,
tavg_du_ss.descr: '3d,Hourly,Instantaneous,Model-Level,Aerosol Concentrations',
tavg_du_ss.template: '%y4%m2%d2_%h2%n2z.nc4',
tavg_du_ss.mode: 'time-averaged',
tavg_du_ss.grid_label: PC720x361-DC ,
tavg_du_ss.splitField: 1,
tavg_du_ss.frequency: 120000 ,
tavg_du_ss.duration: 010000 ,
tavg_du_ss.ref_time: 000000 ,
tavg_du_ss.nbits: 10,
tavg_du_ss.fields: 'DU' , 'DU' ,
'SS' , 'SS' ,
::

inst_ca.format: 'CFIO' ,
inst_ca.descr: '3d,Hourly,Instantaneous,Model-Level,Aerosol Concentrations',
inst_ca.template: '%y4%m2%d2_%h2%n2z.nc4',
inst_ca.mode: 'instantaneous',
inst_ca.grid_label: PC720x361-DC ,
inst_ca.frequency: 010000 ,
inst_ca.frequency: 120000 ,
inst_ca.duration: 010000 ,
inst_ca.ref_time: 000000 ,
inst_ca.nbits: 10,
Expand All @@ -71,7 +100,7 @@ PC720x361-DC.LM: 72
inst_ni.template: '%y4%m2%d2_%h2%n2z.nc4',
inst_ni.mode: 'instantaneous',
inst_ni.grid_label: PC720x361-DC ,
inst_ni.frequency: 010000 ,
inst_ni.frequency: 120000 ,
inst_ni.duration: 010000 ,
inst_ni.ref_time: 000000 ,
inst_ni.nbits: 10,
Expand All @@ -87,7 +116,7 @@ PC720x361-DC.LM: 72
inst_su.template: '%y4%m2%d2_%h2%n2z.nc4',
inst_su.mode: 'instantaneous',
inst_su.grid_label: PC720x361-DC ,
inst_su.frequency: 010000 ,
inst_su.frequency: 120000 ,
inst_su.duration: 010000 ,
inst_su.ref_time: 000000 ,
inst_su.nbits: 10,
Expand Down Expand Up @@ -117,13 +146,30 @@ PC720x361-DC.LM: 72
'DUSV' , 'DU' ,
::

tavg_du_bin.format: 'CFIO' ,
tavg_du_bin.descr: '2d,Hourly,Instantaneous'
tavg_du_bin.template: '%y4%m2%d2_%h2%n2z.nc4',
tavg_du_bin.mode: 'time-averaged'
tavg_du_bin.grid_label: PC720x361-DC ,
tavg_du_bin.splitField: 1,
tavg_du_bin.frequency: 030000 ,
tavg_du_bin.duration: 010000 ,
tavg_du_bin.ref_time: 000000 ,
tavg_du_bin.nbits: 10,
tavg_du_bin.fields: 'DUEM' , 'DU' ,
'DUSD' , 'DU' ,
'DUDP' , 'DU' ,
'DUWT' , 'DU' ,
'DUSV' , 'DU' ,
::

inst_ss_bin.format: 'CFIO' ,
inst_ss_bin.descr: '2d,Hourly,Instantaneous'
inst_ss_bin.template: '%y4%m2%d2_%h2%n2z.nc4',
inst_ss_bin.mode: 'instantaneous'
inst_ss_bin.grid_label: PC720x361-DC ,
inst_ss_bin.splitField: 1,
inst_ss_bin.frequency: 010000 ,
inst_ss_bin.frequency: 060000 ,
inst_ss_bin.duration: 010000 ,
inst_ss_bin.ref_time: 000000 ,
inst_ss_bin.nbits: 10,
Expand All @@ -140,7 +186,7 @@ PC720x361-DC.LM: 72
inst_ca_bin.mode: 'instantaneous'
inst_ca_bin.grid_label: PC720x361-DC ,
inst_ca_bin.splitField: 1,
inst_ca_bin.frequency: 010000 ,
inst_ca_bin.frequency: 120000 ,
inst_ca_bin.duration: 010000 ,
inst_ca_bin.ref_time: 000000 ,
inst_ca_bin.nbits: 10,
Expand All @@ -162,7 +208,7 @@ PC720x361-DC.LM: 72
inst_ni_bin.mode: 'instantaneous',
inst_ni_bin.grid_label: PC720x361-DC ,
inst_ni_bin.splitField: 1,
inst_ni_bin.frequency: 010000 ,
inst_ni_bin.frequency: 120000 ,
inst_ni_bin.duration: 010000 ,
inst_ni_bin.ref_time: 000000 ,
inst_ni_bin.nbits: 10,
Expand All @@ -179,7 +225,7 @@ PC720x361-DC.LM: 72
inst_su_bin.mode: 'instantaneous',
inst_su_bin.grid_label: PC720x361-DC ,
inst_su_bin.splitField: 1,
inst_su_bin.frequency: 010000 ,
inst_su_bin.frequency: 120000 ,
inst_su_bin.duration: 010000 ,
inst_su_bin.ref_time: 000000 ,
inst_su_bin.nbits: 10,
Expand All @@ -198,8 +244,8 @@ PC720x361-DC.LM: 72
inst_2d.template: '%y4%m2%d2_%h2%n2z.nc4',
inst_2d.archive: '%c/Y%y4',
inst_2d.mode: 'instantaneous'
inst_2d.frequency: 010000,
inst_2d.duration: 010000,
inst_2d.frequency: 030000,
inst_2d.duration: 030000,
inst_2d.ref_time: 000000,
inst_2d.grid_label: PC720x361-DC
inst_2d.fields: 'DUSMASS' , 'DU' ,
Expand Down Expand Up @@ -290,40 +336,14 @@ PC720x361-DC.LM: 72
'SO2EMVE' , 'SU' ,
::

tavg_cmass.format: 'CFIO' ,
tavg_cmass.descr: '2d,3-hourly,Time-averaged'
tavg_cmass.template: '%y4%m2%d2_%h2%n2z.nc4',
tavg_cmass.archive: '%c/Y%y4',
tavg_cmass.mode: 'time-averaged'
tavg_cmass.frequency: 030000,
tavg_cmass.duration: 030000,
tavg_cmass.ref_time: 000000,
tavg_cmass.grid_label: PC720x361-DC
tavg_cmass.fields: 'DUCMASS' , 'DU' ,
'DUCMASS25' , 'DU' ,
'SSCMASS' , 'SS' ,
'SSCMASS25' , 'SS' ,
'CACMASSCA.bc' , 'CA.bc' ,
'CACMASSCA.oc' , 'CA.oc' ,
'HNO3CMASS' , 'NI' ,
'NH3CMASS' , 'NI' ,
'NH4CMASS' , 'NI' ,
'NICMASS' , 'NI' ,
'NICMASS25' , 'NI' ,
'SO2CMASS' , 'SU' ,
'SO4CMASS' , 'SU' ,
'DMSCMASS' , 'SU' ,
'MSACMASS' , 'SU' ,
::

#
# 3d diagnostics
#
inst_3d.format: 'CFIO' ,
inst_3d.template: '%y4%m2%d2_%h2%n2z.nc4' ,
inst_3d.archive: '%c/Y%y4' ,
inst_3d.mode: 'instantaneous'
inst_3d.frequency: 010000,
inst_3d.frequency: 060000,
inst_3d.duration: 010000,
inst_3d.ref_time: 000000,
inst_3d.grid_label: PC720x361-DC
Expand Down Expand Up @@ -361,7 +381,7 @@ PC720x361-DC.LM: 72
inst_aod.template: '%y4%m2%d2_%h2%n2z.nc4' ,
inst_aod.archive: '%c/Y%y4' ,
inst_aod.mode: 'instantaneous'
inst_aod.frequency: 010000,
inst_aod.frequency: 060000,
inst_aod.duration: 010000,
inst_aod.ref_time: 000000,
inst_aod.grid_label: PC720x361-DC
Expand All @@ -379,8 +399,8 @@ PC720x361-DC.LM: 72
tavg_2d_rad.template: '%y4%m2%d2_%h2%n2z.nc4',
tavg_2d_rad.archive: '%c/Y%y4',
tavg_2d_rad.mode: 'time-averaged',
tavg_2d_rad.frequency: 030000,
tavg_2d_rad.duration: 030000,
tavg_2d_rad.frequency: 120000,
tavg_2d_rad.duration: 120000,
tavg_2d_rad.ref_time: 000000,
tavg_2d_rad.grid_label: PC720x361-DC
tavg_2d_rad.fields: 'CAEXTTAUCA.bc' , 'CA.bc' ,
Expand Down Expand Up @@ -413,8 +433,8 @@ PC720x361-DC.LM: 72
tavg_3d_rad.template: '%y4%m2%d2_%h2%n2z.nc4',
tavg_3d_rad.archive: '%c/Y%y4',
tavg_3d_rad.mode: 'time-averaged',
tavg_3d_rad.frequency: 030000,
tavg_3d_rad.duration: 030000,
tavg_3d_rad.frequency: 120000,
tavg_3d_rad.duration: 120000,
tavg_3d_rad.ref_time: 000000,
tavg_3d_rad.grid_label: PC720x361-DC
tavg_3d_rad.splitField: 1,
Expand Down
6 changes: 3 additions & 3 deletions tests/parm/gocart/DU2G_instance_DU.rc
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ nbins: 5
pressure_lid_in_hPa: 0.01

# Emissions methods
emission_scheme: ginoux # choose among: fengsha, ginoux, k14
emission_scheme: fengsha # choose among: fengsha, ginoux, k14

# FENGSHA settings
alpha: 0.7
gamma: 1.0
alpha: 0.04
gamma: 0.8
vertical_to_horizontal_flux_ratio_limit: 2.e-04
7 changes: 3 additions & 4 deletions tests/rt.sh
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ if [[ $TESTS_FILE =~ '35d' ]] || [[ $TESTS_FILE =~ 'weekly' ]]; then
TEST_35D=true
fi

BL_DATE=20220516
BL_DATE=20220517
if [[ $MACHINE_ID = hera.* ]] || [[ $MACHINE_ID = orion.* ]] || [[ $MACHINE_ID = cheyenne.* ]] || [[ $MACHINE_ID = gaea.* ]] || [[ $MACHINE_ID = jet.* ]] || [[ $MACHINE_ID = s4.* ]]; then
RTPWD=${RTPWD:-$DISKNM/NEMSfv3gfs/develop-${BL_DATE}/${RT_COMPILER^^}}
else
Expand Down Expand Up @@ -531,10 +531,9 @@ mkdir ${LOG_DIR}
if [[ $ROCOTO == true ]]; then

ROCOTO_XML=${PATHRT}/rocoto_workflow.xml
ROCOTO_STATE=${PATHRT}/rocoto_workflow.state
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this line removed?

ROCOTO_DB=${PATHRT}/rocoto_workflow.db

rm -f $ROCOTO_XML $ROCOTO_DB $ROCOTO_STATE *_lock.db
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is $ROCOTO_STATE removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DusanJovic-NOAA Honestly I don't know when that was changed. It may have come from when I pulled in the latest changes from the develop branch. Looking back a the log history I didn't modify that. I have no problem adding it back in if that is what we should do.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DusanJovic-NOAA it seems to me that these lines were not there until @SamuelTrahanNOAA 's PR 1195.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bbakernoaa Please revert those changes. It is okay to make these changes at this point in the commit since they do not affect the regression test results.

rm -f $ROCOTO_XML $ROCOTO_DB *_lock.db

if [[ $MACHINE_ID = wcoss ]]; then
QUEUE=dev
Expand Down Expand Up @@ -881,7 +880,7 @@ else

rm -f fv3_*.x fv3_*.exe modules.fv3_* keep_tests.tmp
[[ ${KEEP_RUNDIR} == false ]] && rm -rf ${RUNDIR_ROOT}
[[ ${ROCOTO} == true ]] && rm -f ${ROCOTO_XML} ${ROCOTO_DB} ${ROCOTO_STATE} *_lock.db
[[ ${ROCOTO} == true ]] && rm -f ${ROCOTO_XML} ${ROCOTO_DB} *_lock.db
[[ ${TEST_35D} == true ]] && rm -f tests/cpld_bmark*_20*
[[ ${SINGLE_NAME} != '' ]] && rm -f rt.conf.single
fi
Expand Down
4 changes: 4 additions & 0 deletions tests/run_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,10 @@ if [[ $CPLWAV == .true. ]]; then
atparse < ${PATHRT}/parm/ww3_multi.inp.IN > ww3_multi.inp
fi

if [[ $CPLCHM == .true. ]]; then
cp ${PATHRT}/parm/gocart/*.rc .
fi

if [[ $DATM_CDEPS = 'true' ]] || [[ $S2S = 'true' ]]; then
if [[ $HAFS = 'false' ]]; then
atparse < ${PATHRT}/parm/ice_in_template > ice_in
Expand Down
3 changes: 0 additions & 3 deletions tests/tests/control_atm_aerosols
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@ export LIST_FILES="sfcf000.nc \
GFSFLX.GrbF24 \
GFSPRS.GrbF00 \
GFSPRS.GrbF24 \
gocart.inst_aod.20210322_0700z.nc4 \
gocart.inst_aod.20210323_0600z.nc4 \
gocart.tavg_cmass.20210322_0730z.nc4 \
gocart.tavg_cmass.20210323_0430z.nc4 \
RESTART/coupler.res \
RESTART/fv_core.res.nc \
RESTART/fv_core.res.tile1.nc \
Expand Down