-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop]: Add Tutorial chapter to SRW App Documentation #584
[develop]: Add Tutorial chapter to SRW App Documentation #584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gspetro-NOAA Thank you very much for recreating a PR to get the Tutorial chapter back into develop without the binary files!
In PR #562, @mkavulich added information about the behavior of setting EXPT_BASEDIR
as a relative path. It was noted that this information was removed in ConfigWorkflow.rst
as part of this PR. Please add these sentences back in.
Once this has been addressed, I'm ready to approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gspetro-NOAA Thank you very much for addressing my concern! Approving these changes now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gillian, thanks again for being so flexible with the hassle of this re-do process. Just two minor suggestions, everything else looks great.
Co-authored-by: Michael Kavulich <kavulich@ucar.edu>
Co-authored-by: Michael Kavulich <kavulich@ucar.edu>
DESCRIPTION OF CHANGES:
This PR adds a Tutorial chapter to the SRW Documentation. There are descriptions for 5 severe weather events and a full tutorial for the first one (2019061518).
This PR also includes:
Type of change
TESTS CONDUCTED:
None required. Docs can be viewed on my fork at https://srw-ug.readthedocs.io/en/text-tutorial/Tutorial.html# Formerly, tests were run on the following systems:
Since this is the reintroduction of a previously-approved PR, no further testing has been done.
DEPENDENCIES:
N/A
DOCUMENTATION:
All documentation.
ISSUE:
Issue #550
Issue #588
CHECKLIST