Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Enable deterministic verification to be run from staged forecast files #566
[develop] Enable deterministic verification to be run from staged forecast files #566
Changes from 9 commits
1a2be52
23324d2
dcaa3e8
017b07f
c0fef14
3ce8fd6
66b810d
861aabf
c4ca391
a2e9ff9
14bae5f
5fd6f0c
e4d78b4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this logic can be simplified to the following:
The nested "and"s are superfluous, and
if run_task_get_obs_ccpa
does not require an "else" statement.The same logic should apply to the subsequent changes for
run_task_get_obs_mrms
andrun_task_get_obs_ndas
as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkavulich Yes I noticed that too but had decided to make only the minimal change necessary (in terms of when you do a diff) since all this will get rewritten anyway pretty soon. I'll put in your suggestion and rerun.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkavulich I put in the new simpler logic and reran the vx tests (with intel compiler only) and all 3 succeeded. The other (fundamental) tests aren't affected by this, so I didn't rerun them. I'll let the Jenkins testing handle those.