-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] S3 doc updates #1104
[develop] S3 doc updates #1104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the Indy-Severe-Data.tgz
file has moved as well. It would be best to update .cicd/scripts/srw_metric.sh
to use https://noaa-ufs-srw-pds.s3.amazonaws.com/experiment-user-cases/release-public-v2.1.0/METplus-vx-sample/Indy-Severe-Weather.tgz
rather than https://noaa-ufs-srw-pds.s3.amazonaws.com/sample_cases/release-public-v2.1.0/Indy-Severe-Weather.tgz
, which no longer exists.
Outside of this, these changes look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @EdwardSnyder-NOAA, for modifying the srw_metric.sh script as well!
Approving now.
Thanks @MichaelLueken! Good catch with the srw_metric.sh script! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further testing of the SRW metrics script suggests that it would probably be best to continue using the verification data from the release-public-v2.1.0
directory rather than the release-public-v2.2.0
verification data. Several changes would need to be made to the overall script in order to allow the release-public-v2.2.0
verification data to be read, just for stat_analysis not to compute a skill score in the end. For this reason, I suggest changing back to release-public-v2.1.0
for now while looking into the warning messages that are generated while attempting to run the metrics code using release-public-v2.2.0
.
Co-authored-by: Michael Lueken <63728921+MichaelLueken@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the modification to use the v2.1.0 verification data! Approving once again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
As part of the data governance initiative, all s3 buckets will need some sort of versioning control. To meet these needs the AWS S3 Bucket was reorganized with the develop data stored under a 'develop-date' folder and the verification sample case and the document case (current_release_data) moved under a new folder called 'experiment-user-cases'. --------- Co-authored-by: Michael Lueken <63728921+MichaelLueken@users.noreply.github.com>
DESCRIPTION OF CHANGES:
As part of the data governance initiative, all s3 buckets will need some sort of versioning control. To meet these needs the AWS S3 Bucket was reorganized with the develop data stored under a 'develop-date' folder and the verification sample case and the document case (current_release_data) moved under a new folder called 'experiment-user-cases'.
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
DOCUMENTATION:
ISSUE:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):