Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Added an option for RRFS external model files used as ICS and LBCS #1089
[develop] Added an option for RRFS external model files used as ICS and LBCS #1089
Changes from all commits
e72d6ec
23e009d
fbc06d4
e63f5c3
37c5863
5f4f07c
891e7cf
a0f37ed
d07ea9a
70fc576
361a59c
07b8333
cd2b1fb
e41e622
5ab710c
e1fd4d6
14dbabf
e5664d4
fca4e09
d532777
b72e661
bc9d731
8d62da6
3754499
d60a540
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this section is more general and the mention of RRFS specifically should not go here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is included specifically because the new test case for the RRFS is not staged in standard locations, as many other WE2E experiments (data pulled from the SRW App Data Bucket). It is also a ready reference for obtaining readily available initialization data besides the HPSS or other sources ("Obtained and staged by the user from a different source"), for users external to NOAA who may not be aware of actual data sources.
The question of where to get the data to initialize the UFS/SRW model is one of the most frequently asked questions (sometimes directly sent to Maoyi), so it looks that including this info in the section on "Input and Output" is likely very beneficial to users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this still needs to be more generic. There are several different models that can be pulled by SRW from the NODD buckets. It is not just RRFS.