Skip to content

Commit

Permalink
[develop] Update WM and UPP hashes and minor rearrangement of WE2E co…
Browse files Browse the repository at this point in the history
…verage tests that fail on certain platforms (#799)

* The WM and UPP hashes in the Externals.cfg file were updated to current versions.
* The nco_grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson_mynn_lam3km test that is constantly failing on Cheyenne GNU and the grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta test on Hera Intel have been moved to platforms where the tests successfully run.
* Minor changes to the DT_ATMOS for the RRFS_CONUS_25km grid were made to allow the WE2E tests run after updating to the current UFS-WM hash. Changes to DT_ATMOS was was also required for for the RRFS_AK_3km grid.
  • Loading branch information
MichaelLueken authored Jun 9, 2023
1 parent cc92e50 commit 294e18b
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 10 deletions.
10 changes: 7 additions & 3 deletions .cicd/Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ pipeline {
// choice(name: 'SRW_PLATFORM_FILTER', choices: ['all', 'cheyenne', 'gaea', 'hera', 'jet', 'orion', 'pclusternoaav2use1', 'azclusternoaav2eus1', 'gclusternoaav2usc1'], description: 'Specify the platform(s) to use')
// Use the line below to enable the PW AWS cluster
// choice(name: 'SRW_PLATFORM_FILTER', choices: ['all', 'cheyenne', 'gaea', 'hera', 'jet', 'orion', 'pclusternoaav2use1'], description: 'Specify the platform(s) to use')
choice(name: 'SRW_PLATFORM_FILTER', choices: ['all', 'cheyenne', 'gaea', 'hera', 'jet', 'orion'], description: 'Specify the platform(s) to use')
// Use the line below to re-enable Gaea
// choice(name: 'SRW_PLATFORM_FILTER', choices: ['all', 'cheyenne', 'gaea', 'hera', 'jet', 'orion'], description: 'Specify the platform(s) to use')
choice(name: 'SRW_PLATFORM_FILTER', choices: ['all', 'cheyenne', 'hera', 'jet', 'orion'], description: 'Specify the platform(s) to use')
// Allow job runner to filter based on compiler
choice(name: 'SRW_COMPILER_FILTER', choices: ['all', 'gnu', 'intel'], description: 'Specify the compiler(s) to use to build')
// Uncomment the following line to re-enable comprehensive tests
Expand Down Expand Up @@ -76,7 +78,8 @@ pipeline {
axes {
axis {
name 'SRW_PLATFORM'
values 'cheyenne', 'gaea', 'hera', 'jet', 'orion' //, 'pclusternoaav2use1', 'azclusternoaav2eus1', 'gclusternoaav2usc1'
// values 'cheyenne', 'gaea', 'hera', 'jet', 'orion' //, 'pclusternoaav2use1', 'azclusternoaav2eus1', 'gclusternoaav2usc1'
values 'cheyenne', 'hera', 'jet', 'orion' //, 'pclusternoaav2use1', 'azclusternoaav2eus1', 'gclusternoaav2usc1'
}

axis {
Expand All @@ -90,7 +93,8 @@ pipeline {
exclude {
axis {
name 'SRW_PLATFORM'
values 'gaea', 'jet', 'orion' //, 'pclusternoaav2use1' , 'azclusternoaav2eus1', 'gclusternoaav2usc1'
// values 'gaea', 'jet', 'orion' //, 'pclusternoaav2use1' , 'azclusternoaav2eus1', 'gclusternoaav2usc1'
values 'jet', 'orion' //, 'pclusternoaav2use1' , 'azclusternoaav2eus1', 'gclusternoaav2usc1'
}

axis {
Expand Down
4 changes: 2 additions & 2 deletions Externals.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ protocol = git
repo_url = https://github.com/ufs-community/ufs-weather-model
# Specify either a branch name or a hash but not both.
#branch = develop
hash = 36d6e16
hash = e403bb4
local_path = sorc/ufs-weather-model
required = True

Expand All @@ -21,7 +21,7 @@ protocol = git
repo_url = https://github.com/NOAA-EMC/UPP
# Specify either a branch name or a hash but not both.
#branch = develop
hash = 22cfb88
hash = dccb321
local_path = sorc/UPP
required = True

Expand Down
2 changes: 1 addition & 1 deletion tests/WE2E/machine_suites/coverage.cheyenne.gnu
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
grid_CONUS_25km_GFDLgrid_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR
grid_RRFS_CONUScompact_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
grid_RRFS_NA_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta
grid_SUBCONUS_Ind_3km_ics_NAM_lbcs_NAM_suite_GFS_v16
nco_grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson_mynn_lam3km
specify_EXTRN_MDL_SYSBASEDIR_ICS_LBCS
1 change: 1 addition & 0 deletions tests/WE2E/machine_suites/coverage.gaea
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR
grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta
grid_SUBCONUS_Ind_3km_ics_RAP_lbcs_RAP_suite_RRFS_v1beta_plot
nco_ensemble
nco_grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson_mynn_lam3km
1 change: 0 additions & 1 deletion tests/WE2E/machine_suites/coverage.hera.intel.nco
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_grib2_2019061200
get_from_HPSS_ics_GDAS_lbcs_GDAS_fmt_netcdf_2022040400_ensemble_2mems
get_from_HPSS_ics_HRRR_lbcs_RAP
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp_regional_plot
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,5 @@ task_get_extrn_lbcs:
LBC_SPEC_INTVL_HRS: 3
USE_USER_STAGED_EXTRN_FILES: true
task_run_fcst:
DT_ATMOS: 180
RESTART_INTERVAL: 1 2 5
2 changes: 1 addition & 1 deletion tests/test_python/test_calculate_cost.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ def test_calculate_cost(self):
test_dir = os.path.dirname(os.path.abspath(__file__))
USHdir = os.path.join(test_dir, "..", "..", "ush")
params = calculate_cost(os.path.join(USHdir, 'config.community.yaml'))
self.assertCountEqual(params, [180, 28689, 180, 28689])
self.assertCountEqual(params, [150, 28689, 150, 28689])
4 changes: 2 additions & 2 deletions ush/predef_grid_params.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
ESGgrid_NY: 131
ESGgrid_PAZI: 0.0
ESGgrid_WIDE_HALO_WIDTH: 6
DT_ATMOS: 180
DT_ATMOS: 150
LAYOUT_X: 5
LAYOUT_Y: 2
BLOCKSIZE: 40
Expand Down Expand Up @@ -349,7 +349,7 @@
ESGgrid_NY: 1020
ESGgrid_PAZI: 0.0
ESGgrid_WIDE_HALO_WIDTH: 6
DT_ATMOS: 10
DT_ATMOS: 30
LAYOUT_X: 30
LAYOUT_Y: 17
BLOCKSIZE: 40
Expand Down

0 comments on commit 294e18b

Please sign in to comment.