Skip to content

Commit

Permalink
Remove GSI dependency of rrfs_utl assuming gsi is already built.
Browse files Browse the repository at this point in the history
  • Loading branch information
@danielabdi-noaa
danielabdi-noaa committed Aug 30, 2022
1 parent 552c78f commit 1ed233a
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion sorc/CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ if (BUILD_RRFS_UTILS)
CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX} -DCMAKE_INSTALL_BINDIR=${CMAKE_INSTALL_BINDIR}
BUILD_ALWAYS TRUE
STEP_TARGETS build
DEPENDS GSI

This comment has been minimized.

Sign in to view

Copy link
@christopherwharrop-noaa

christopherwharrop-noaa Aug 30, 2022

Collaborator

Is there a corresponding find_package(GSI) to compensate for this? GSI is required for building rrfs_utl, so the dependency checks need to make sure it is available at the cmake step before the build starts. If the assumption is that GSI is built separately elsewhere, then GSI must be treated as any other dependency in the same way that NetCDF, etc is treated. I do not believe GSI provides a generic find_package() functionality yet.

This comment has been minimized.

Sign in to view

Copy link
@danielabdi-noaa

danielabdi-noaa Aug 30, 2022

Author Collaborator

@christopherwharrop-noaa Yes, there is a find_package(gsi) and find_package(ncdiag) in rrfst_utils cmake file, but this "fix" is mainly because of the need to build each component separately for NCO compliance. If you happen to have GSI built already, building rrfs_utls alone is possible.

This comment has been minimized.

Sign in to view

Copy link
@christopherwharrop-noaa

christopherwharrop-noaa Aug 30, 2022

Collaborator

That will work if the intent is to have GSI installed in the ufs-srweather-app source tree via the ufs-srweather-app build system. However, I am not so sure whether the find_package actually will work correctly if GSI is installed independently outside of the UFS app environment. Depending on what NCO is actually requiring, you may want to test whether the find_package(gsi) actually works for an externally installed GSI.
)
endif()

Expand Down

0 comments on commit 1ed233a

Please sign in to comment.