Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding one regression test for fractional grid #196

Merged

Conversation

ShanSunNOAA
Copy link
Collaborator

This is regarding Issue #178.

A test at C384 and 0.25deg ocean using a fractional land mask is added, based on the develop branch of /ufs-community/ufs-s2s-model/ on Sept. 22, 2020 (94a4cc6).

Testing was performed on Hera and the model output is at /scratch2/BMC/gsd-fv3-dev/Shan.Sun/S2S_RT/rt_192127/.

Please let me know if you have any questions. Thanks!

@DeniseWorthen @junwang-noaa

@junwang-noaa
Copy link
Collaborator

Shan, would yo please commit the log files after you finish RT on hera? I will run RT from your branch on orion and wcoss (wcoss is currently not available, have to run RT when it's back).

@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Sep 24, 2020 via email

@junwang-noaa
Copy link
Collaborator

Shan, I am thinking maybe it's better to add fractional grid test based on cpld_fv3_ccpp_384_mom6_cice_cmeps_ww3_1d_bmark_rt which has wave component?

…_ww3_1d_bmark_rt_frac";

-- Needed to modify cpld_fv3_mom6_cice_ww3_bmark_rt_run.IN. With it, the non-fractional test of "cpld_fv3_ccpp_384_mom6_cice_cmeps_ww3_1d_bmark_rt" produced bitwise identical results.
@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Sep 25, 2020 via email

@DeniseWorthen
Copy link
Collaborator

The wave frac test needs to wait until the bugfix for the MOM input template (#195) gets committed. Otherwise it is not testing waves.

I can commit the bug fix soon---hera and orion are done but I've been waiting for dell to come back. Then once it was back I had to wait until the baselines were sync'd. That took most of yesterday and the final baseline did not transfer completely (it seems to have died).

@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Sep 25, 2020 via email

@DeniseWorthen
Copy link
Collaborator

So the FV3 PR (#200) is supposed to come after this. I don't believe a baseline has been created for this test yet?

Has that task been assigned or does someone need to do it? After the baseline is created, will the full RT need to be run again including the new test?

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Oct 1, 2020 via email

@junwang-noaa
Copy link
Collaborator

Shan, it looks to me you haven't update CEMSP and FV3 yet in your branch. Would you please do:

checkout your regression_test_p6_20200924 branch
%cd FV3
%git checkout 9e1ba7c
%git submodule update --init --recursive
%git log
(you should see:
commit 9e1ba7c7448a8d009f39b5588e9498a7dbab1c60
Author: Dom Heinzeller dom.heinzeller@icloud.com
Date: Sat Sep 26 07:15:33 2020 -0600
...)
%cd ../CMEPS
%git checkout emc/develop
%git log
(you should see:
commit 4d50adf2c63749241afbc028cbe245881b087585
Author: Rahul Mahajan aerorahul@users.noreply.github.com
Date: Wed Sep 30 18:30:57 2020 -0400
...)
%cd ../(now you are in ufs-s2s-model)
%git status
(your should see
...
modified: CMEPS (new commits, untracked content)
modified: FV3 (new commits)
..)
%git commit -a -m"update subcomponents in s2s"
%git push origin regression_test_p6_20200924

We can then run RT.

@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Oct 5, 2020 via email

@DeniseWorthen
Copy link
Collaborator

I discovered on Friday a problem with the frac_grid input in non-frac mode when testing for PR #194. Ice fraction was appearing on points where slmsk=1. Shan was able to fix the current oro_data for this issue. The sfc and phy input is good as is:

In sfc data, I had made sure that for all ice points, slmsk=2, and for the rest of not-all-land points, slmsk=0, which is floor(land_frac). However, in oro data, slmsk was still using nint(land_frac). All I did today was set to replace nint(land_frac) by slmsk=floor(land_frac) in the oro data. So you will see all changes along coastlines because of this.

So the short answer is that this was done in sfc data already. gfs data does not use "slmsk".

She generated new input with the fixed oro data here: /scratch1/BMC/gsd-fv3-dev/fv3data

We should be sure to update the FV3_input_frac on all platforms before creating a new baseline for this test. I wasn't sure what the status was of the baselines over the weekend so I have not yet done this on any platform.

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Oct 5, 2020 via email


# Restart
else
# Restart files
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shan, Have you tested the restart reproducibility with fractional test (FV3-MOM6-CICE6)?

…cmeps_ww3_1d_bmark_rt", which

passed the regression test, and its corresponding fractional landmask test "cpld_fv3_ccpp_384_mom6_cice_cmeps_ww3_1d_bmark_rt_frac".
@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Oct 5, 2020 via email

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Oct 5, 2020

Shan, I just copied C192.mx050_frac C384.mx025_frac C384_l127.mx025_frac C96.mx025_frac C96.mx100_frac C384.mx050_frac from /scratch1/BMC/gsd-fv3-dev/fv3data (created on 10/2) to /scratch1/NCEPDEV/nems/emc.nemspara/RT/FV3-MOM6-CICE5/develop-20200928/FV3_input_frac. Since in your PR, you added two tests: cpld_fv3_ccpp_384_mom6_cice_cmeps_2d_atm_flux_frac and cpld_fv3_ccpp_384_mom6_cice_cmeps_ww3_1d_bmark_rt_frac, would you please also add cpld_fv3_ccpp_384_mom6_cice_cmeps_2d_atm_flux_frac in rt.conf? After that, please run RT for the two tests and then let me know your run directory, I can copy the results to the baseline, then we will run the full regression test.

So if you have cpld_fv3_ccpp_384_mom6_cice_cmeps_2d_atm_flux_frac test, then it can serve as the control test for your fractional grid restart reproducibility test.

@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Oct 5, 2020 via email

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Oct 5, 2020 via email

@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Oct 5, 2020 via email

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Oct 5, 2020 via email

…l landmask:

(1) cpld_fv3_ccpp_384_mom6_cice_cmeps_2d_atm_flux
(2) cpld_fv3_ccpp_384_mom6_cice_cmeps_2d_atm_flux_frac
(3) cpld_fv3_ccpp_384_mom6_cice_cmeps_ww3_1d_bmark_rt
(4) cpld_fv3_ccpp_384_mom6_cice_cmeps_ww3_1d_bmark_rt_frac
@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Oct 5, 2020 via email

…-00000.nc" comparison temporarily, before a solution comes up;

-- All 4 tests passed regression tests.
@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Oct 7, 2020 via email

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Oct 8, 2020

Shan, I run full RT on orion, it looks to me we need to comment out all the tests "ufs.s2s.cpl.r." except the cpld_fv3_ccpp_mom6_cice_cmeps_6h_debug test, in which the ufs.s2s.cpl.r.2016-10-03-21600.nc is reproducible from run to run.

@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Oct 8, 2020 via email

…orarily in all tests, except "cpld_fv3_ccpp_mom6_cice_cmeps_6h_debug";

-- All regression tests in rt.conf have passed.
@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Oct 8, 2020 via email

@DeniseWorthen
Copy link
Collaborator

We have BM ICs only for the first and 15th of each month; the 2013-04-01 date was chosen because if the model was going to fail after updating the code, that date tended to give quick failures (vs not blowing up until day 31 of 35).

Changing the bmark RT date won't work because we only have the first and 15th.

Have you generated frac_grid ICs for the BM dates? I can't remember.

@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Oct 8, 2020 via email

@DeniseWorthen
Copy link
Collaborator

We'll have to add a new directory in the right place to hold the frac_grid BM data but that would be OK.

Would you need to re-generate the input after the fix you made from last Friday?

@junwang-noaa: What do you think? We could commit only the non-bmark frac grid test now if we've got pressure to move forward for the unification.

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Oct 8, 2020 via email

@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Oct 8, 2020 via email

@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Oct 8, 2020 via email

@DeniseWorthen
Copy link
Collaborator

In fv3_conf/cpld_fv3_mom6_cice_ww3_bmark_rt_run.IN for example, we set BM_IC to the special IC directory. Depending on platform, that directory has either sym-links to the actual input area or actual copies of the input.

@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Oct 8, 2020 via email

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Oct 8, 2020 via email

@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Oct 8, 2020 via email

@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Oct 9, 2020 via email

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Oct 9, 2020 via email

@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Oct 9, 2020 via email

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Oct 9, 2020 via email

@binli2337 binli2337 merged commit 2ac573a into ufs-community:develop Oct 9, 2020
@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Oct 9, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants