Use hpc-stack libraries in ufs-s2s-model #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request replaces PR 184. This pull request is ready for reviews. |
conf/configure.fv3.hera.intel
Outdated
| @@ -180,6 +180,6 @@ LDFLAGS += $(LIBS) | |||
|
|
|||
| ifdef InNemsMakefile | |||
| FFLAGS += $(ESMF_INC) | |||
| CPPFLAGS += -traditional | |||
| EXTLIBS = $(NCEPLIBS) $(ESMF_LIB) $(LDFLAGS) $(NETCDF_LIB) | |||
| CPPFLAGS += -DFV3_CPLD -traditional | |||
There was a problem hiding this comment.
May I ask why do we need to add FV3_CPLD back?
There was a problem hiding this comment.
It will be removed.
| @@ -39,7 +39,7 @@ include $(ESMFMKFILE) | |||
| ESMF_INC = $(ESMF_F90COMPILEPATHS) | |||
|
|
|||
| NEMSIOINC = -I$(NEMSIO_INC) | |||
| NCEPLIBS = $(POST_LIB) $(NEMSIO_LIB) $(G2_LIB4) $(G2TMPL_LIB) $(BACIO_LIB4) $(SP_LIBd) $(W3EMC_LIBd) $(W3NCO_LIBd) $(CRTM_LIB) $(JASPER_LIB) -lpng -lz | |||
There was a problem hiding this comment.
So is JASPER_LIB defined in hpc-stack? what is the value of it?
There was a problem hiding this comment.
JASPER_LIB is not defined in hpc-stack. However, JASPER_ROOT is defined.
…igure.fv3.wcoss_dell_p3.
junwang-noaa
approved these changes
Sep 22, 2020
DeniseWorthen
approved these changes
Sep 22, 2020
MinsukJi-NOAA
pushed a commit
to MinsukJi-NOAA/ufs-s2s-model
that referenced
this pull request
Sep 24, 2020
Co-authored-by: BinLi-NOAA <bin.li@noaa.gov>
|
@binli2337 |
MinsukJi-NOAA
pushed a commit
to MinsukJi-NOAA/ufs-s2s-model
that referenced
this pull request
Oct 7, 2020
* Use hpc-stack libraries in ufs-s2s-model (ufs-community#191) * Update .gitmodules and submodule pointer for fv3atm for PR ufs-community#157 (RRTMG cloud overlap method update) (ufs-community#193) * Bugfix/wave1dtest (ufs-community#195) * fix MOM6 input template used by the cpld_fv3_ccpp_384_mom6_cice_cmeps_ww3_1d_bmark_rt test * Remove PIO as part of S2S model build in CMEPS and use hpc-stack (ufs-community#199) * update CMEPS submodule pointer (ufs-community#205) * Merge with upstream and fix conflicts Co-authored-by: BinLi-NOAA <bin.li@noaa.gov> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: Denise Worthen <denise.worthen@noaa.gov> Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
ShanSunNOAA
pushed a commit
to ShanSunNOAA/ufs-s2s-model
that referenced
this pull request
Oct 28, 2020
…nity#191) * Update modulefiles for cheyenne.{gnu,intel}, gaea.intel, jet.intel; change modulefile for hera.gnu so that it matches the other modulefiles * Correct typo EMSF -> ESMF in modulefiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update module files to use hpc-stack libraries
Specific notes
Issues Fixed #174
Are changes expected to change answers?
Specific changes:
Testing performed:
Hashes used for testing: