Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code updates for one step cold start #176

Merged
merged 15 commits into from
Sep 16, 2020

Conversation

junwang-noaa
Copy link
Collaborator

@junwang-noaa junwang-noaa commented Sep 9, 2020

Description of changes

This PR contains the code changes for one step cold start.

Specific notes

Issues Fixed (include github issue #):

Are changes expected to change answers?

  • bit for bit (yes) with current run sequence

Specific changes:

  • changes in parm directory (yes)
  • changes in module files (no)
  • new tests added (yes)

Testing performed:

  • machines: hera, orion, dell
  • details:

Hashes used for testing:

  • NEMS: 9d05172b
  • CMEPS: 5e63bd4
  • FV3: 90d5eaff
  • MOM6: e42147c5
  • CICE: 285985c
  • WW3: 96e3f3a8
  • FMS: f61416fe
  • stochastic_physics: ffdd19bc

Co-authored by: Denise Worthen Denise.Worthen@noaa.gov

Dependency:

FV3 PR #168
MOM6 PR #33

s2s PR#176

@junwang-noaa junwang-noaa changed the title S2s cemps ic code updates for one step cold start Sep 9, 2020
@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Sep 10, 2020

I don't think we need a special nems.configure.medcoldcmeps_atm_ocn_ice_1step.IN.

The test (cpld_fv3_ccpp_mom6_cice_cmeps_1stepcold_atm_flux) can use the existing nems.configure.medcmeps_atm_ocn_ice.IN but in the test you would set the variable use_coldstart = false:

In the test:

export NEMS_CONFIGURE="nems.configure.medcmeps_atm_ocn_ice.IN"
export use_coldstart="false"

@junwang-noaa
Copy link
Collaborator Author

junwang-noaa commented Sep 10, 2020 via email

@DeniseWorthen
Copy link
Collaborator

That's right. As long as FV3 considers restart_interval=0 to be equivalent to restart_interval=fhmax we should be fine.

The case name determines what string the mediator restart file name will start with. For the 1-step coldstart, we want it to write a mediator file with the case_name "ufs.s2s".

@junwang-noaa junwang-noaa marked this pull request as ready for review September 16, 2020 02:37
export TEST_DESCR="Fully coupled FV3-CCPP-MOM6-CICE-CMEPS system - 1 step cold start"

export CNTL_DIR="RT-Baselines_1stepcold_ccpp_cmeps"
export CNTLMED_DIR="RT-Baselines_1stepcold_ccpp_cmeps"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think can also be an empty string since there is no control mediator directory.

Copy link
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@junwang-noaa
Copy link
Collaborator Author

Denise/Bin, this PR is ready to merge.

@DeniseWorthen DeniseWorthen merged commit f710412 into ufs-community:develop Sep 16, 2020
ShanSunNOAA pushed a commit to ShanSunNOAA/ufs-s2s-model that referenced this pull request Oct 28, 2020
* update to pre-existing land perts scheme, ready for addition of the new scheme
* updates to land perts scheme, so that namelist input and control_type variables are in generic (i.e., variable agnostic) arrays
* Phil's ccpp changes
* minor bug fix
* Comitting stochastic physics updates
* Comitting FV3 submodules updates
* Updates for minimal set of regression tests.
* lndp sub-module clean-up
* Updates to tests to include new input parameters for revised land pert scheme (lndp).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants