Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup/chgres cube modules #462

Closed
wants to merge 3 commits into from
Closed

Cleanup/chgres cube modules #462

wants to merge 3 commits into from

Conversation

kgerheiser
Copy link
Contributor

@kgerheiser kgerheiser commented Apr 26, 2021

Making this a draft PR to start, but I ran the regression tests and all passed.

In this PR:

Thoughts on this?

There was a cyclic dependency between write_data.F90 and surface.F90/atmosphere.F90.
@GeorgeGayno-NOAA
Copy link
Collaborator

Making this a draft PR to start, but I ran the regression tests and all passed.

In this PR:

As an FYI, I was planning to remove the unused packages under my own branch. If you want to do that here, then remove those libraries from all the build modules and update the README.md file. I like what you are doing, but you may be trying to do too many things under one PR.

Thoughts on this?

@kgerheiser
Copy link
Contributor Author

kgerheiser commented Apr 26, 2021

Fair enough. It just kind of ended up that way as I was figuring out the code. I will split it up into 2 PRs. You can do the find_package thing.

@kgerheiser kgerheiser closed this Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants