Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making this a draft PR to start, but I ran the regression tests and all passed.
In this PR:
Add the remaining code into modules (Put rest of chgres_cube code into modules #461), and this leads to a circular dependency between write_data and atomsphere.F90/surface.F90. I move out the target fields into their own module similar to how
input_data.F90
contains all the_input_grid
fields.Split
input_data.F90
into 3 modules:atm_input_data.mo
,sfc_input_data_mod
,nst_input_data_mod
, to make the files more managable. (Split input_data.F90 intoatm_input_data
,sfc_input_data
, andnst_target_data
#460)Remove
find_package(w3emc)
andfind_package(gfsio)
(some packages required in CMakeLists.txt which are no longer needed? #449)Thoughts on this?