develop: Various chgres_cube bug fixes and code improvements #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user provides a geogrid file and any of the calls in this process fail, the code will now fail on an error. Also, added a check to ensure input and geogrid grid sizes match. Addresses Issue ufs-community#228
…properly formatted such that the code finds no variable entries to read. Addresses Issue ufs-community#228
…sed erroneous soil types. Addresses Issue ufs-community#228
Addresses Issue ufs-community#228
|
@LarissaReames-NOAA The authoritative repo was updated this morning. Merge these changes to your fork. Then, I will do my final review and merge. |
Done. |
|
I compiled the branch at 840d5a8 on WCOSS-Dell. All chgres_cube regression tests passed. |
Anything left to change before merge? |
GeorgeGayno-NOAA
requested changes
Nov 30, 2020
|
Compiled the branch at 90b1f0d on WCOSS-Dell. All chgres_cube regression tests passed. Comments on error handling were addressed. Will merge. |
GeorgeGayno-NOAA
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses all of the items listed in Issue #228 . Each item in that issue is addressed with its own commit.