release/public-v2: Various chgres_cube bug fixes and code improvements #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses Issue ufs-community#228
…sed erroneous soil types. Addresses Issue ufs-community#228
…properly formatted such that the code finds no variable entries to read. Addresses Issue ufs-community#228
If the user provides a geogrid file and any of the calls in this process fail, the code will now fail on an error. Also, added a check to ensure input and geogrid grid sizes match. Addresses Issue ufs-community#228
…TILS into release/public-v2
| @@ -4956,6 +4958,8 @@ subroutine read_input_sfc_grib2_file(localpet) | |||
| where(slmsk_save == 1) dummy2d_i = 1 | |||
|
|
|||
| call search(dummy2d_8,dummy2d_i,i_input,j_input,1,230) | |||
| else | |||
There was a problem hiding this comment.
This fixes a problem I encountered using HRRR data with surface climo fields. The input data from wgrib2 is 4-bit, but esmf expects 8 bit, so all data has to be converted using the real() command, saving the 8-bit form of the data from dummy2d in to dummy2d_8, which is then broadcast using esmf. Before I added this, if sotyp_from_climo = true, the dummy2d_8 array wouldn't be re-populated with the correct soil (or fill) data from dummy2d, and it would still have the data from the previous use of dummy2d_8, which was skin temperature.
There was a problem hiding this comment.
Thanks! Good catch!
JeffBeck-NOAA
approved these changes
Nov 23, 2020
a2f74fb to
d16cc0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses all of the listed items in Issue #228. Code compiles and passes all current and future regression tests on Jet.